Chore: use old repo URL for maven releases #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
approved these changes
Mar 30, 2023
paullatzelsperger
pushed a commit
to paullatzelsperger/tractusx-edc
that referenced
this pull request
May 4, 2023
…use_old_repourl_for_maven_release Chore: use old repo URL for maven releases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
This PR sets a hard-coded repo URL for publishing Maven artifacts, and sets it to the "old"
catenax-ng/product-edcrepository.WHY
Until we can publish to OSSRH/MavenCentral (#166) we still need to publish to GitHub Packages.
GH requires that Maven coordinates be unique in the same org.
Since both the old Product-EDC repo and our fork of Tractusx-EDC are in the
catenax-ngorg, we can only publish packages from either one, not both.So for the time being we publish "into" the old repo.
FURTHER NOTES
Consumers of the packages must also use the old repo url:
repositories { maven { url = uri("https://maven.pkg.github.com/catenax-ng/product-edc") credentials { username = project.findProperty("gpr.user") as String? ?: System.getenv("USERNAME") password = project.findProperty("gpr.key") as String? ?: System.getenv("TOKEN") } } }this will go away once we have implemented the OSSRH/MavenCentral release process (#166)