Fix: PipelineService datasources pull transfers #1520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolf4ood
requested changes
Aug 29, 2024
Comment on lines
24
to
25
| runtimeOnly(project(":edc-extensions:dataplane:pipeline-service")) | ||
|
|
There was a problem hiding this comment.
I would not put the dependency here, but in the edc-dataplane-base
There was a problem hiding this comment.
you're right, thank you, updated in d72b9a2!
|
wolf4ood
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Similar to an issue raised in the Upstream, it adds an extension where basically overrides PipelineService implementation to include the new fix.
WHY
Regarding an issue found and fixed in the (most recent version of the) EDC where the DataSources were not closed in PULL transfers, we faced the need of having this fix on a 0.7.X version as well.
FURTHER NOTES
The transfer() method has Span annotation related with the OpenTelemetry in the Upstream, however was removed here since the addition of dependency just for this case seemed unnecessary (and for any other usage, there is in the upstream).
If need for signalling the OT instrumentation is needed, please raise a comment.
Closes #1519