chore: disable dim int test #1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ndr-brt
approved these changes
May 13, 2024
| @@ -98,7 +95,7 @@ static void afterAll() { | |||
| bdrsServer.stop(); | |||
| } | |||
|
|
|||
| @Test | |||
| //@Test | |||
There was a problem hiding this comment.
Could it be just @Disabled?
There was a problem hiding this comment.
Unfortunatelly no, since this depends on environment variable being there and it still fails in initialization even if it's disabled.
There was a problem hiding this comment.
that's a bummer! LGTM the way it is then!
There was a problem hiding this comment.
Yeah it's ugly, it's marked as removal anyway i doubt that we will have a config for running this nightly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
disable DIM int test
WHY
currenty try to run it in the
verify-dimworkflow but it fails for missing configuration. For now we just comment it as@Testtill we decide to configure it or delete itFURTHER NOTES
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Closes # <-- insert Issue number if one exists