-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: register CX Policy Functions #1075
Merged
paullatzelsperger
merged 13 commits into
eclipse-tractusx:main
from
paullatzelsperger:feat/add_tests_for_framework_constraints
Feb 21, 2024
Merged
feat: register CX Policy Functions #1075
paullatzelsperger
merged 13 commits into
eclipse-tractusx:main
from
paullatzelsperger:feat/add_tests_for_framework_constraints
Feb 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
added
enhancement
New feature or request
critical
All issues that will definitely be in the milestone they are planned for
iatp
labels
Feb 20, 2024
paullatzelsperger
force-pushed
the
feat/add_tests_for_framework_constraints
branch
from
February 20, 2024 20:17
d822641
to
3e801f5
Compare
wolf4ood
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Quality Gate passedIssues Measures |
paullatzelsperger
deleted the
feat/add_tests_for_framework_constraints
branch
February 21, 2024 13:24
This was referenced Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
critical
All issues that will definitely be in the milestone they are planned for
enhancement
New feature or request
iatp
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
This PR registers the new C-X Policy constraint functions with the
PolicyEngine
and dynamically binds them.In addition, some E2E-Tests were added leveraging the IATP test configuration.
WHY
The policy functions need to be registered so that VerifiableCredentials are properly evaluated.
FURTHER NOTES
0.5.2-SNAPSHOT
to get the very latest upstream fixes from Feb 20, 2024. We can pin the version to a nightly version the day after.Closes # <-- insert Issue number if one exists