Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: register CX Policy Functions #1075

Conversation

paullatzelsperger
Copy link
Contributor

@paullatzelsperger paullatzelsperger commented Feb 20, 2024

WHAT

This PR registers the new C-X Policy constraint functions with the PolicyEngine and dynamically binds them.

In addition, some E2E-Tests were added leveraging the IATP test configuration.

WHY

The policy functions need to be registered so that VerifiableCredentials are properly evaluated.

FURTHER NOTES

  • had to go back to using 0.5.2-SNAPSHOT to get the very latest upstream fixes from Feb 20, 2024. We can pin the version to a nightly version the day after.
  • MIW integration tests are disabled, as the SummaryCredential eval functions would interfere with the new policy eval functions. Removing them altogether and cleaning up all the SummaryCredential stuff will be done in another PR

Closes # <-- insert Issue number if one exists

@paullatzelsperger paullatzelsperger added enhancement New feature or request critical All issues that will definitely be in the milestone they are planned for iatp labels Feb 20, 2024
@paullatzelsperger paullatzelsperger self-assigned this Feb 20, 2024
@paullatzelsperger paullatzelsperger force-pushed the feat/add_tests_for_framework_constraints branch from d822641 to 3e801f5 Compare February 20, 2024 20:17
Copy link
Contributor

@wolf4ood wolf4ood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link

Quality Gate Passed Quality Gate passed

Issues
7 New issues

Measures
0 Security Hotspots
No data about Coverage
2.2% Duplication on New Code

See analysis details on SonarCloud

@paullatzelsperger paullatzelsperger merged commit 08bd745 into eclipse-tractusx:main Feb 21, 2024
25 checks passed
@paullatzelsperger paullatzelsperger deleted the feat/add_tests_for_framework_constraints branch February 21, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
critical All issues that will definitely be in the milestone they are planned for enhancement New feature or request iatp
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

2 participants