Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: removes Jws2020CryptoSuite implementation #1036

Conversation

wolf4ood
Copy link
Contributor

@wolf4ood wolf4ood commented Feb 8, 2024

WHAT

removes Jws2020CryptoSuite implementation

WHY

not needed anymore

FURTHER NOTES

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Closes #1035

@wolf4ood wolf4ood requested review from ndr-brt and paullatzelsperger and removed request for ndr-brt February 8, 2024 10:03
Copy link

sonarqubecloud bot commented Feb 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@@ -66,7 +66,6 @@ public void createAsset(String id) {
* Stores BPN groups
*/
public void storeBusinessPartner(String bpn, String... groups) {
var culo = "ciao";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whops! 🤣

Copy link
Contributor

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪓

@wolf4ood wolf4ood merged commit c519e31 into eclipse-tractusx:main Feb 8, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

Remove Jws2020CryptoSuite implementation
2 participants