Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tests): Tests use ServiceExtensionContext injection #1034

Merged

Conversation

rafaelmag110
Copy link
Contributor

WHAT

This PR introduces a refactorization of service extesion tests to remove unecessary instantiations of the ServiceExtensionContext and ObjectFactory.

WHY

Refactor.

Closes #972

@rafaelmag110 rafaelmag110 force-pushed the chore/refactor_context_tests branch from 45ae2fa to 553de60 Compare February 7, 2024 16:25
@rafaelmag110 rafaelmag110 marked this pull request as ready for review February 7, 2024 16:27
@rafaelmag110 rafaelmag110 changed the title chore: refactor test to use context injection refactor(tests): Tests use ServiceExtensionContext injection Feb 7, 2024
@rafaelmag110 rafaelmag110 force-pushed the chore/refactor_context_tests branch from 553de60 to 796ae72 Compare February 8, 2024 10:29
Copy link

sonarqubecloud bot commented Feb 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@wolf4ood wolf4ood self-requested a review February 8, 2024 14:43
Copy link
Contributor

@wolf4ood wolf4ood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks :)

@wolf4ood wolf4ood merged commit 2e12f40 into eclipse-tractusx:main Feb 8, 2024
25 checks passed
@rafaelmag110 rafaelmag110 deleted the chore/refactor_context_tests branch December 16, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

Refactor tests to use context where needed in method args
2 participants