Skip to content

Commit

Permalink
Merge pull request #929 from paullatzelsperger/feat/allow_additional_…
Browse files Browse the repository at this point in the history
…volume_mounts

feat(helm): allow additional volume mounts
  • Loading branch information
paullatzelsperger authored Dec 15, 2023
2 parents 2498215 + e7d7f13 commit 704bef1
Show file tree
Hide file tree
Showing 8 changed files with 42 additions and 19 deletions.
11 changes: 5 additions & 6 deletions charts/tractusx-connector-azure-vault/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -167,8 +167,8 @@ helm install my-release tractusx-edc/tractusx-connector-azure-vault --version 0.
| controlplane.ssi.oauth.tokenurl | string | `""` | The URL (of KeyCloak), where access tokens can be obtained |
| controlplane.tolerations | list | `[]` | |
| controlplane.url.protocol | string | `""` | Explicitly declared url for reaching the dsp api (e.g. if ingresses not used) |
| controlplane.volumeMounts | list | `[]` | declare where to mount [volumes](https://kubernetes.io/docs/concepts/storage/volumes/) into the container |
| controlplane.volumes | list | `[]` | [volume](https://kubernetes.io/docs/concepts/storage/volumes/) directories |
| controlplane.volumeMounts | string | `nil` | declare where to mount [volumes](https://kubernetes.io/docs/concepts/storage/volumes/) into the container |
| controlplane.volumes | string | `nil` | [volume](https://kubernetes.io/docs/concepts/storage/volumes/) directories |
| customCaCerts | object | `{}` | Add custom ca certificates to the truststore |
| customLabels | object | `{}` | To add some custom labels |
| dataplane.affinity | object | `{}` | |
Expand Down Expand Up @@ -250,8 +250,8 @@ helm install my-release tractusx-edc/tractusx-connector-azure-vault --version 0.
| dataplane.service.type | string | `"ClusterIP"` | [Service type](https://kubernetes.io/docs/concepts/services-networking/service/#publishing-services-service-types) to expose the running application on a set of Pods as a network service. |
| dataplane.tolerations | list | `[]` | |
| dataplane.url.public | string | `""` | Explicitly declared url for reaching the public api (e.g. if ingresses not used) |
| dataplane.volumeMounts | list | `[]` | declare where to mount [volumes](https://kubernetes.io/docs/concepts/storage/volumes/) into the container |
| dataplane.volumes | list | `[]` | [volume](https://kubernetes.io/docs/concepts/storage/volumes/) directories |
| dataplane.volumeMounts | string | `nil` | declare where to mount [volumes](https://kubernetes.io/docs/concepts/storage/volumes/) into the container |
| dataplane.volumes | string | `nil` | [volume](https://kubernetes.io/docs/concepts/storage/volumes/) directories |
| fullnameOverride | string | `""` | |
| imagePullSecrets | list | `[]` | Existing image pull secret to use to [obtain the container image from private registries](https://kubernetes.io/docs/concepts/containers/images/#using-a-private-registry) |
| install.postgresql | bool | `true` | |
Expand All @@ -260,9 +260,8 @@ helm install my-release tractusx-edc/tractusx-connector-azure-vault --version 0.
| postgresql.auth.database | string | `"edc"` | |
| postgresql.auth.password | string | `"password"` | |
| postgresql.auth.username | string | `"user"` | |
| postgresql.enabled | bool | `false` | |
| postgresql.jdbcUrl | string | `"jdbc:postgresql://{{ .Release.Name }}-postgresql:5432/edc"` | |
| postgresql.primary.persistence | string | `nil` | |
| postgresql.primary.persistence.enabled | bool | `false` | |
| postgresql.readReplicas.persistence.enabled | bool | `false` | |
| serviceAccount.annotations | object | `{}` | |
| serviceAccount.create | bool | `true` | |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -377,6 +377,9 @@ spec:
{{- end }}
{{- end }}
volumeMounts:
{{- if .Values.controlplane.volumeMounts }}
{{- toYaml .Values.controlplane.volumeMounts | nindent 12 }}
{{- end}}
- name: "configuration"
mountPath: "/app/opentelemetry.properties"
subPath: "opentelemetry.properties"
Expand All @@ -391,6 +394,9 @@ spec:
- name: "tmp"
mountPath: "/tmp"
volumes:
{{- if .Values.controlplane.volumeMounts }}
{{- toYaml .Values.controlplane.volumes | nindent 8 }}
{{- end}}
- name: "configuration"
configMap:
name: {{ include "txdc.fullname" . }}-controlplane
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,9 @@ spec:
{{- end }}
{{- end }}
volumeMounts:
{{- if .Values.dataplane.volumeMounts }}
{{- toYaml .Values.dataplane.volumeMounts | nindent 12 }}
{{- end}}
- name: "configuration"
mountPath: "/app/opentelemetry.properties"
subPath: "opentelemetry.properties"
Expand All @@ -256,6 +259,9 @@ spec:
- name: "tmp"
mountPath: "/tmp"
volumes:
{{- if .Values.dataplane.volumes }}
{{- toYaml .Values.dataplane.volumes | nindent 8 }}
{{- end}}
- name: "configuration"
configMap:
name: {{ include "txdc.fullname" . }}-dataplane
Expand Down
10 changes: 5 additions & 5 deletions charts/tractusx-connector-azure-vault/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -245,9 +245,9 @@ controlplane:
# -- If preset enables certificate generation via cert-manager cluster-wide issuer
clusterIssuer: ""
# -- declare where to mount [volumes](https://kubernetes.io/docs/concepts/storage/volumes/) into the container
volumeMounts: []
volumeMounts:
# -- [volume](https://kubernetes.io/docs/concepts/storage/volumes/) directories
volumes: []
volumes:
# -- [resource management](https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/) for the container
resources: {}
# We usually recommend not to specify default resources and to leave this as a conscious
Expand Down Expand Up @@ -445,9 +445,9 @@ dataplane:
# -- If preset enables certificate generation via cert-manager cluster-wide issuer
clusterIssuer: ""
# -- declare where to mount [volumes](https://kubernetes.io/docs/concepts/storage/volumes/) into the container
volumeMounts: []
volumeMounts:
# -- [volume](https://kubernetes.io/docs/concepts/storage/volumes/) directories
volumes: []
volumes:
# -- [resource management](https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/) for the container
resources: {}
# We usually recommend not to specify default resources and to leave this as a conscious
Expand Down Expand Up @@ -499,7 +499,7 @@ postgresql:
jdbcUrl: "jdbc:postgresql://{{ .Release.Name }}-postgresql:5432/edc"
primary:
persistence:
enabled: false
enabled: false
readReplicas:
persistence:
enabled: false
Expand Down
8 changes: 4 additions & 4 deletions charts/tractusx-connector/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -161,8 +161,8 @@ helm install my-release tractusx-edc/tractusx-connector --version 0.6.0-rc2 \
| controlplane.ssi.oauth.tokenurl | string | `""` | The URL (of KeyCloak), where access tokens can be obtained |
| controlplane.tolerations | list | `[]` | |
| controlplane.url.protocol | string | `""` | Explicitly declared url for reaching the dsp api (e.g. if ingresses not used) |
| controlplane.volumeMounts | list | `[]` | declare where to mount [volumes](https://kubernetes.io/docs/concepts/storage/volumes/) into the container |
| controlplane.volumes | list | `[]` | [volume](https://kubernetes.io/docs/concepts/storage/volumes/) directories |
| controlplane.volumeMounts | string | `nil` | declare where to mount [volumes](https://kubernetes.io/docs/concepts/storage/volumes/) into the container |
| controlplane.volumes | string | `nil` | [volume](https://kubernetes.io/docs/concepts/storage/volumes/) directories |
| customCaCerts | object | `{}` | Add custom ca certificates to the truststore |
| customLabels | object | `{}` | To add some custom labels |
| dataplane.affinity | object | `{}` | |
Expand Down Expand Up @@ -244,8 +244,8 @@ helm install my-release tractusx-edc/tractusx-connector --version 0.6.0-rc2 \
| dataplane.service.type | string | `"ClusterIP"` | [Service type](https://kubernetes.io/docs/concepts/services-networking/service/#publishing-services-service-types) to expose the running application on a set of Pods as a network service. |
| dataplane.tolerations | list | `[]` | |
| dataplane.url.public | string | `""` | Explicitly declared url for reaching the public api (e.g. if ingresses not used) |
| dataplane.volumeMounts | list | `[]` | declare where to mount [volumes](https://kubernetes.io/docs/concepts/storage/volumes/) into the container |
| dataplane.volumes | list | `[]` | [volume](https://kubernetes.io/docs/concepts/storage/volumes/) directories |
| dataplane.volumeMounts | string | `nil` | declare where to mount [volumes](https://kubernetes.io/docs/concepts/storage/volumes/) into the container |
| dataplane.volumes | string | `nil` | [volume](https://kubernetes.io/docs/concepts/storage/volumes/) directories |
| fullnameOverride | string | `""` | |
| imagePullSecrets | list | `[]` | Existing image pull secret to use to [obtain the container image from private registries](https://kubernetes.io/docs/concepts/containers/images/#using-a-private-registry) |
| install.postgresql | bool | `true` | |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -376,6 +376,9 @@ spec:
{{- end }}
{{- end }}
volumeMounts:
{{- if .Values.controlplane.volumeMounts }}
{{- toYaml .Values.controlplane.volumeMounts | nindent 12 }}
{{- end}}
- name: "configuration"
mountPath: "/app/opentelemetry.properties"
subPath: "opentelemetry.properties"
Expand All @@ -390,6 +393,9 @@ spec:
- name: "tmp"
mountPath: "/tmp"
volumes:
{{- if .Values.controlplane.volumeMounts }}
{{- toYaml .Values.controlplane.volumes | nindent 8 }}
{{- end}}
- name: "configuration"
configMap:
name: {{ include "txdc.fullname" . }}-controlplane
Expand Down
6 changes: 6 additions & 0 deletions charts/tractusx-connector/templates/deployment-dataplane.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,9 @@ spec:
{{- end }}
{{- end }}
volumeMounts:
{{- if .Values.dataplane.volumeMounts }}
{{- toYaml .Values.dataplane.volumeMounts | nindent 12 }}
{{- end}}
- name: "configuration"
mountPath: "/app/opentelemetry.properties"
subPath: "opentelemetry.properties"
Expand All @@ -255,6 +258,9 @@ spec:
- name: "tmp"
mountPath: "/tmp"
volumes:
{{- if .Values.dataplane.volumeMounts }}
{{- toYaml .Values.dataplane.volumes | nindent 8 }}
{{- end}}
- name: "configuration"
configMap:
name: {{ include "txdc.fullname" . }}-dataplane
Expand Down
8 changes: 4 additions & 4 deletions charts/tractusx-connector/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -245,9 +245,9 @@ controlplane:
# -- If preset enables certificate generation via cert-manager cluster-wide issuer
clusterIssuer: ""
# -- declare where to mount [volumes](https://kubernetes.io/docs/concepts/storage/volumes/) into the container
volumeMounts: []
volumeMounts:
# -- [volume](https://kubernetes.io/docs/concepts/storage/volumes/) directories
volumes: []
volumes:
# -- [resource management](https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/) for the container
resources: {}
# We usually recommend not to specify default resources and to leave this as a conscious
Expand Down Expand Up @@ -443,9 +443,9 @@ dataplane:
# -- If preset enables certificate generation via cert-manager cluster-wide issuer
clusterIssuer: ""
# -- declare where to mount [volumes](https://kubernetes.io/docs/concepts/storage/volumes/) into the container
volumeMounts: []
volumeMounts:
# -- [volume](https://kubernetes.io/docs/concepts/storage/volumes/) directories
volumes: []
volumes:
# -- [resource management](https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/) for the container
resources: {}
# We usually recommend not to specify default resources and to leave this as a conscious
Expand Down

0 comments on commit 704bef1

Please sign in to comment.