Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/update all workflows #42

Merged
merged 23 commits into from
Jan 25, 2024
Merged

Fix/update all workflows #42

merged 23 commits into from
Jan 25, 2024

Conversation

almadigabor
Copy link
Contributor

@almadigabor almadigabor commented Jan 10, 2024

Description

  • Merge helm lint, test and kyverno workflows into a single one
  • Update the helm lint and test action steps to new versions
  • Skip helm upgradeability step for now until we have a working helm chart
  • Updated the chart releaser action action steps to new versions
  • Update the copyright headers in all workflows
  • Use the kyverno/action-install-cli action instead of manual install
  • Skip kyverno job for now as it is not in the focus

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

Copy link
Member

@fty4 fty4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some things which could be changed.
Please also consider renaming the PR title (and maybe not make the PR bigger - more PRs might be better.)

Also wondering why the certs chart is removed. What is the reason here?

.github/workflows/helm-lint-test.yaml Outdated Show resolved Hide resolved
.github/kyverno-policies/require-run-as-non-root-user.yaml Outdated Show resolved Hide resolved
.github/workflows/helm-lint-test.yaml Outdated Show resolved Hide resolved
.github/workflows/helm-lint-test.yaml Outdated Show resolved Hide resolved
.github/workflows/helm-lint-test.yaml Outdated Show resolved Hide resolved
@almadigabor almadigabor self-assigned this Jan 11, 2024
@almadigabor almadigabor changed the title Fix/update all workflows Fix/update all workflows & cleanup outdated chart components Jan 11, 2024
@almadigabor
Copy link
Contributor Author

Found some things which could be changed. Please also consider renaming the PR title (and maybe not make the PR bigger - more PRs might be better.)

Also wondering why the certs chart is removed. What is the reason here?

Hey @fty4, thanks for the review and great feedback! The problem here that even if the workflows are fixed, the test will not pass. So I would just revert the changes I made to the chart, merge the workflow fixes and open a separate PR for the chart cleanup. This way we can have smaller PRs and won't need IP checks due to the large amount of changes.

I've removed the certs subchart after a discussion with @evegufy. She suggested that it was only used for DAPS which is obsolete now.

I will still make some changes to kyverno as it does not work with the bitnami postgresql chart as expected regarding initContainers before concluding this PR.

@almadigabor almadigabor changed the title Fix/update all workflows & cleanup outdated chart components Fix/update all workflows Jan 12, 2024
@almadigabor almadigabor merged commit 53f92c2 into main Jan 25, 2024
3 of 4 checks passed
@evegufy evegufy deleted the fix/update-all-workflows branch August 13, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants