-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/update all workflows #42
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found some things which could be changed.
Please also consider renaming the PR title (and maybe not make the PR bigger - more PRs might be better.)
Also wondering why the certs chart is removed. What is the reason here?
Co-authored-by: Marco Lecheler <[email protected]>
Co-authored-by: Marco Lecheler <[email protected]>
Co-authored-by: Marco Lecheler <[email protected]>
Hey @fty4, thanks for the review and great feedback! The problem here that even if the workflows are fixed, the test will not pass. So I would just revert the changes I made to the chart, merge the workflow fixes and open a separate PR for the chart cleanup. This way we can have smaller PRs and won't need IP checks due to the large amount of changes. I've removed the certs subchart after a discussion with @evegufy. She suggested that it was only used for DAPS which is obsolete now. I will still make some changes to kyverno as it does not work with the bitnami postgresql chart as expected regarding initContainers before concluding this PR. |
Description
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: