Skip to content

Commit

Permalink
chore: fix helm checks workflow for client rate limiter error (#63)
Browse files Browse the repository at this point in the history
change to `helm install` instead of `ct install` to don't run into that error anymore because when using helm install (also on local Minikube) the chart (for instance for this PR #53) installs without error.
also: add an informational step to describe the node for more awareness about available resources in the future and upgrade some actions.
  • Loading branch information
evegufy authored Apr 16, 2024
1 parent 919de1c commit 59d30d4
Showing 1 changed file with 9 additions and 6 deletions.
15 changes: 9 additions & 6 deletions .github/workflows/helm-checks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:
fetch-depth: 0

- name: Set up Helm
uses: azure/setup-helm@v3
uses: azure/setup-helm@b7246b12e77f7134dc2d460a3d5bad15bbe29390 # v4.1.0
with:
version: v3.12.1

Expand Down Expand Up @@ -89,13 +89,16 @@ jobs:
fetch-depth: 0

- name: Kubernetes KinD Cluster
uses: container-tools/kind-action@v2
uses: container-tools/kind-action@0ad70e2299366b0e1552c7240f4e4567148f723e #v2.0.4
with:
# upgrade version, default (v0.17.0) uses node image v1.21.1 and doesn't work with more recent node image versions
version: v0.20.0
# default value for event_name != workflow_dispatch
node_image: ${{ github.event.inputs.node_image || 'kindest/node:v1.27.3' }}

- name: Informational - describe node
run: kubectl describe node

- name: Build simple data backend
id: build-simple-data-backend
uses: docker/build-push-action@4a13e500e55cf31b7a5d59a38ab2040ab0f42f56 # v5.1.0
Expand All @@ -105,10 +108,9 @@ jobs:
tags: kind-registry:5000/simple-data-backend:testing

- name: Set up Helm
uses: azure/setup-helm@v3
uses: azure/setup-helm@b7246b12e77f7134dc2d460a3d5bad15bbe29390 # v4.1.0
with:
version: ${{ github.event.inputs.helm_version || 'latest' }}
token: ${{ secrets.GITHUB_TOKEN }}

- uses: actions/setup-python@v5
with:
Expand All @@ -129,8 +131,9 @@ jobs:
run: ct install --charts charts/simple-data-backend --target-branch ${{ github.event.repository.default_branch }} --helm-extra-set-args "--set image.repository=kind-registry:5000/simple-data-backend --set image.tag=testing"

- name: Install chart and run tests (umbrella)
run: ct install --charts charts/umbrella --target-branch ${{ github.event.repository.default_branch }}

run: |
helm install umbrella charts/umbrella --namespace install --create-namespace --debug
helm uninstall umbrella --namespace install
## Skip upgrade for now until a working chart is released
#- name: Run helm upgrade
Expand Down

0 comments on commit 59d30d4

Please sign in to comment.