bug: #778 return empty page result instead of HTTP 404 #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ds-lcapellino
added
bug
ds-lcapellino
force-pushed
the
bug/778-return-empty-pageResult-instead-404
branch
from
10c11e3 to
3b4bee1
Compare
ds-lcapellino
changed the title
ds-lcapellino
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in the /contracts API where an HTTP404 is returned in case of no present contract agreement IDs. Since this API returns a PageResult, the response should be HTTP 200 with an empty PageResult. This bug was discovered with the migration to EDC 0.7.0 (#778)
Warning logs are also added with this PR.
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: