Missing Disabling Tooltip for Save Button in Create / Edit Notification

[mkanal]

Description

Current behavior

• Save button is disabled to tooltip provides guidance for user why this is disabled

Expected behavior

• Disabling tooltip should show reason why button is disabled

Steps to reproduce the Bug

1. Login to Trace-X with role Admin
2. Create notification quality alert
3. Try to save quality alert

[ds-mmaul]

resolved issue similiar to policy edit/create. on hover over the save button, the form gets validated. By this, the user gets an indicator on where exactly to change/add input

[ds-crehm]

Tested on E2E: LGTM
Necessary input fields are highlighted after hovering over save button. And the shown tooltip is descriptive.

Ready for review.

[mkanal]

@ds-crehm @ds-mmaul

Disabling Tooltip is not working as extended.

• Create Quality notification from scratch
• Fill in all fields to have a valid from
• Remove Deadline
  Current behavior
• Save Button is enabled and stays enabled - no info why save is not possible. No validation of form-.
  Expected behaviro
• Save Button should be disabled with disabling tooltip

• Disbling Tooltip on Edit Notification might not be correct.
  

• incorrect tooltip on View details - View details is working on row level
  

[ds-mmaul]

@ds-crehm @ds-mmaul

Disabling Tooltip is not working as extended.

• Create Quality notification from scratch
• Fill in all fields to have a valid from
• Remove Deadline
  Current behavior
• Save Button is enabled and stays enabled - no info why save is not possible. No validation of form-.
  Expected behaviro
• Save Button should be disabled with disabling tooltip

• Disbling Tooltip on Edit Notification might not be correct.
  
• incorrect tooltip on View details - View details is working on row level
  

Hi @mkanal ,
From the text i understand the following regarding the the first point:

current behaviour:
-> Without target date save button is enabled
expected behaviour:
-> Without target date save button should be disabled with form validation on date

Generally, target date is not a required field, thats why the form is valid without date (even without initially entering and then removing). So it possible to create a notification without target date. If a required target date is necessary, we need to adjust BE and FE on that.

To the two last points, this menu is for actions on multiple notifications. I made it clear with toasts and tooltips, that this functionality is not implemeneted yet, since this will be handled in this issue #922 . Currently actions on notifications are possible by the menu icon in the corresponding row of the notification

[mkanal]

Hi @ds-mmaul
why is save not possible in the case when target date is not set. Please analyse the error and kindly ask for a solution. Deadline seams to block save action.

[ds-mmaul]

The save button is enabled no matter if target date is set or not.

@ds-crehm @ds-mmaul

Disabling Tooltip is not working as extended.

• Create Quality notification from scratch
• Fill in all fields to have a valid from
• Remove Deadline
  Current behavior
• Save Button is enabled and stays enabled - no info why save is not possible. No validation of form-.
  Expected behaviro
• Save Button should be disabled with disabling tooltip

You mentioned that the expected behaviour is to make it disabled when deadline is empty. This requires adjustments in FE and BE because currently its possible to create notifications without target date. I will create an Issue for that if you confirm that we should make this change

[ds-mmaul]

Issues resolved as discussed:

• disabled mulit notification action menu with tooltip
• fixed bug when creating/editing notifications, deleting the target date results in no action when clicking on save icon (even though its enabled). This is now fixed and the save button will actually save the notification

[mkanal]

LGFM works as intended. PO acceptance in behalf of @jzbmw

[ds-crehm]

When creating a notification and then only adding a part and not changing any other data, following tooltip is shown:

Doesn't seem correct to me, as this tooltip was intended for the situation when I'm editing a notification and not having done any changes yet.