Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustments to the EDC policy in EDC Client library #978

Closed
2 tasks done
Assignees
Labels
bug Something isn't working public public and not spammy R24.5 release-hot-fix pbi is relevant for current release and for hotfix path

Comments

@mkanal
Copy link
Contributor

mkanal commented May 15, 2024

Blocked by

Description

Current behaviour

  • Policy #Action: Policy ordl:action is capital letter

Expected behavior

  • Update IRS client lib to latest version NO SNAPSHOT
  • Search for the ticket number in the code. Fix the implementation after IRS has been updated
    -> NotificationEdcFacade Line 127: GetCatalog Query needs to be changed -> see examples in the image down below
    -> IrsPolicyResponse updated to the latest model
    -> PolicyMapper make sure that IrsResponse will be mapped to the correct EDC Policy
    Here we need to make sure to add the cx-policy context for example (check with @ds-jhartmann ) and the ontology version (1.2?)

GEC_E2E_Testing

GEC_E2E_Testing

1. Trace-X FOSS: Check if HM001 and HM002 is present in the dDTR of GEC. Refer to https://confluence.catena-x.net/pages/viewpage.action?pageId=123605489
1.a) Lookup corresponding C-X globalAssetId in GEC dDTR  (EDC https://customer-edc.apps.dev.aws.alm.oncite.io / BPN BPNL00000007QNOK)
2. Exchange notifications on these level. 
3. Provisioning of SingleLevelBomAsBuilt (Trace-X) 
3.a) Link C-X ID of GEC HM001 and HM002 to SerialPart Future Car X
4. Policy ordl:action is capitel letter - small letter "use" 
5. @context: { 
   "@vocab" : "https://w3id.org/edc/v0.0.1/ns/",
   "edc": "https://w3id.org/edc/v0.0.1/ns/",
   "cx-policy": "https://w3id.org/catenax/policy/",
   "ordl": "https://w3id.org/ns/ordl/2/",
}
6. "dct:type": {
   "@id" : expanded version "https://..UpateQualityAlertNotification" 
 }
7. ontology version 1.2  

For namespaces of quality notifications:

Image

@ds-lcapellino
Copy link
Contributor

Fix is deployed on E2E with the main branch.

@ds-lcapellino ds-lcapellino mentioned this issue May 22, 2024
2 tasks
ds-jhartmann pushed a commit that referenced this issue May 22, 2024
ds-jhartmann pushed a commit that referenced this issue May 22, 2024
ds-jhartmann pushed a commit that referenced this issue May 22, 2024
ds-jhartmann pushed a commit that referenced this issue May 22, 2024
ds-jhartmann pushed a commit that referenced this issue May 22, 2024
ds-jhartmann pushed a commit that referenced this issue May 22, 2024
@ds-crehm
Copy link
Contributor

Tested on E2E:
Can send & receive notifications without issues
Ready for review

@ds-crehm ds-crehm moved this from test to review in Trace-X May 23, 2024
@mkanal mkanal added public public and not spammy and removed BLOCKED Issues are blocked by other issues labels Jun 5, 2024
@mkanal mkanal moved this from review to done in Trace-X Jun 10, 2024
@mkanal
Copy link
Contributor Author

mkanal commented Jun 10, 2024

PO acceptance in behalf of @jzbmw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working public public and not spammy R24.5 release-hot-fix pbi is relevant for current release and for hotfix path
Projects
Status: done
4 participants