Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONTRACT_MGMT][BACKEND] Unable to receive data from EDC for contract information #963

Closed
ds-lcapellino opened this issue May 14, 2024 · 4 comments · Fixed by eclipse-tractusx/item-relationship-service#645 or #983
Assignees
Labels
backend Backend related issues bug Something isn't working contract_management contract_management in trace-X public public and not spammy R24.5 release-hot-fix pbi is relevant for current release and for hotfix path

Comments

@ds-lcapellino
Copy link
Contributor

ds-lcapellino commented May 14, 2024

Description

Due to the EDC 0.7.0 migration, the contract view in the FE shows many null values. However, this functionality worked in the past with EDC 0.5.3.

Current behavior

  • No data are loaded in contract view, except the contractAgreementId.

Expected behavior

  • Information provided by EDC Management API are shown for contractAgreementId.
  • Error is shown if no data could be located over EDC Mgmt API for contractAgreementId

Out of scope

  • End date is not shown

Steps to reproduce the Bug

  • Login with role admin
  • Open Contract View
  • Browse through table
@ds-lcapellino ds-lcapellino moved this to backlog in Trace-X May 14, 2024
@ds-lcapellino ds-lcapellino added the bug Something isn't working label May 14, 2024
@ds-lcapellino ds-lcapellino moved this from backlog to next in Trace-X May 14, 2024
@ds-lcapellino ds-lcapellino changed the title Unable to receive data from EDC for contract information [BACKEND] Unable to receive data from EDC for contract information May 14, 2024
@ds-lcapellino ds-lcapellino added the backend Backend related issues label May 14, 2024
@mkanal mkanal added the contract_management contract_management in trace-X label May 14, 2024
@mkanal mkanal changed the title [BACKEND] Unable to receive data from EDC for contract information [CONTRACT_MGMT][BACKEND] Unable to receive data from EDC for contract information May 14, 2024
@ds-lcapellino ds-lcapellino added R24.5 release-hot-fix pbi is relevant for current release and for hotfix path labels May 14, 2024
@ds-mwesener ds-mwesener moved this from next to wip in Trace-X May 14, 2024
@ds-lcapellino
Copy link
Contributor Author

With the EDC version 0.7.0, the prefix "edc:" got removed int the contract agreement response.
How contract agreement were returned in EDC 0.5.3:
[ { "@type" : "edc:ContractAgreement", "@id" : "abc1", "edc:assetId" : "registry-asset", "edc:policy" : { ...
How they are returned in 0.7.0:
[ { "@type": "ContractAgreement", "@id": "047c1046-2fca-4597-85d5-ebf5bed806e9", "assetId": "registry-asset", "policy": { ...

We will fix this in the edc-client-lib.

@ds-lcapellino
Copy link
Contributor Author

Issue is solved with #983.
Verified on E2E environment.

Image

@ds-lcapellino ds-lcapellino moved this from wip to test in Trace-X May 15, 2024
@ds-crehm
Copy link
Contributor

Tested on E2E-A & E2E-B:
Contract details are visible again including contract id, counterparty address, creation date, state and raw json data.
Ready for review.

@ds-crehm ds-crehm reopened this May 15, 2024
@ds-crehm ds-crehm assigned mkanal and unassigned ds-crehm May 15, 2024
@ds-crehm ds-crehm moved this from test to review in Trace-X May 15, 2024
@mkanal
Copy link
Contributor

mkanal commented Jun 5, 2024

LGFM. PO Accpetance in behalf of @jzbmw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend related issues bug Something isn't working contract_management contract_management in trace-X public public and not spammy R24.5 release-hot-fix pbi is relevant for current release and for hotfix path
Projects
Status: done
3 participants