Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of notification which are revoked from receiver side because of policy expiration #521

Closed
3 tasks
Tracked by #639
ds-jleyh opened this issue Dec 21, 2023 · 6 comments · Fixed by catenax-ng/tx-traceability-foss#953
Assignees
Labels
concept issues describing to work on a concept

Comments

@ds-jleyh
Copy link
Contributor

ds-jleyh commented Dec 21, 2023

As dev
I want a proper concept how to implement policy expiration in notification process
so that I have clear vision what and how to implement this stuff

Link

Hints / Details

  • Inside the library irs-edc-client ContractNegotiationService method startNewNegotiation starts the negotation including the necessary policy check.
  • The "policy checker" checks if policy permissions matches and policy is expired (validUntil is before currentDataTime).
  • If one of the checks fails, a UsagePolicyException is thrown and has to be handled by the requestor
  • UsagePolicyException should provide the reason why the policy is not matching (Mismatch because of missing policy or mismatch because of policy expired)
  • In case notification process fails because of a policy mismatch which is indicated by a UsagePolicyException this should be shown to the user in a sufficient way.
  1. Extension for org.eclipse.tractusx.irs.edc.client.policy.PolicyCheckerService to provide reason why policy is not valid. e.g. UsagePolicyPermissionException and UsagePolicyExpiredException
  2. Notification process ends with UsagePolicyPermissionException or UsagePolicyExpiredException this is shown to the user in a sufficient way in frontend
  3. Clarify with devs how UsagePolicyException is handled now in the code

Acceptance Criteria

  • Concept for Handling of notification which are revoked from receiver side because policy expires covers
    • User is aware of policy expiry on frontend side
    • system provides a suitable error message why the asset is not accessible

Out of Scope

  • Further activities on handling of assets with expired policy
@github-project-automation github-project-automation bot moved this to inbox in Trace-X Dec 21, 2023
@jzbmw jzbmw added the concept issues describing to work on a concept label Jan 8, 2024
@jzbmw jzbmw moved this from inbox to backlog in Trace-X Jan 8, 2024
@jzbmw
Copy link
Contributor

jzbmw commented Jan 8, 2024

@mkanal isn't that something already in work?

@jzbmw jzbmw changed the title ⭐[CONCEPT] Handling of notification which are revoked from receiver side because of policy exiration Handling of notification which are revoked from receiver side because of policy exiration Jan 8, 2024
@mkanal
Copy link
Contributor

mkanal commented Jan 8, 2024

@jzbmw no there is nothing in progress.

@mkanal
Copy link
Contributor

mkanal commented Jan 29, 2024

@ds-crehm PR review is done. There are some remarks. Please check

@ds-crehm
Copy link
Contributor

@ds-alexander-bulgakov, please review. Thanks!

@ds-alexander-bulgakov
Copy link
Contributor

No obscurities could be found, the concept is ready for PO-review. FYI @jzbmw

@jzbmw jzbmw moved this from review to done in Trace-X Feb 6, 2024
@mkanal mkanal changed the title Handling of notification which are revoked from receiver side because of policy exiration Handling of notification which are revoked from receiver side because of policy expiration Feb 6, 2024
@ds-crehm
Copy link
Contributor

Implemented by #656

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
concept issues describing to work on a concept
Projects
Status: done
Development

Successfully merging a pull request may close this issue.

5 participants