Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comprehensible disabling Tooltip on action "Create quality topic" #1069

Closed
1 task
mkanal opened this issue Jun 20, 2024 · 6 comments · Fixed by #1224
Closed
1 task

Comprehensible disabling Tooltip on action "Create quality topic" #1069

mkanal opened this issue Jun 20, 2024 · 6 comments · Fixed by #1224
Assignees
@mkanal
Labels
5 - Frontend Refactoring

Comments

@mkanal
Copy link
Contributor

mkanal commented Jun 20, 2024 •
edited
Loading

As user
I want comprehensible and understandable disabling tooltip on Customer Parts
so that I able to follow why action is disabled

Hints / Details

  • ...

Acceptance Criteria

  • comprehensible and understandable disabling tooltip on action "Create/Edit Notification) for "Customer" Parts. (e.g. Notifications cannot be sent on customer parts.)

Out of Scope

  • ...
@mkanal mkanal added this to Trace-X Jun 20, 2024
@github-project-automation github-project-automation bot moved this to inbox in Trace-X Jun 20, 2024
@mkanal mkanal moved this from inbox to backlog in Trace-X Jul 16, 2024
@ds-mmaul ds-mmaul self-assigned this Jul 17, 2024
@ds-mmaul ds-mmaul moved this from backlog to wip in Trace-X Jul 17, 2024
@ds-mmaul ds-mmaul mentioned this issue Jul 17, 2024
Merged
2 tasks
ds-mwesener added a commit that referenced this issue Jul 17, 2024
@ds-mwesener
Merge pull request #1224 from eclipse-tractusx/chore/#1069-adjust-too…
b70280a 
…ltip-notification-creation

chore(notifications): 1069 adjust notification creation disabling too…
@ds-mmaul ds-mmaul moved this from wip to test in Trace-X Jul 17, 2024
@ds-crehm
Copy link
Contributor

Tested on e2e: LGTM.
Tooltips are understandable and explain exactly what the requirements are to create notifications for selected parts.

Ready for review.

@ds-crehm ds-crehm reopened this Jul 18, 2024
@ds-crehm ds-crehm moved this from test to review in Trace-X Jul 18, 2024
@ds-crehm ds-crehm assigned mkanal and unassigned ds-mmaul and ds-crehm Jul 18, 2024
@mkanal
Copy link
Contributor Author

mkanal commented Jul 18, 2024 •
edited
Loading

image

Instead of "Requires a change on the quality notification" - "No changes; nothing saved."

@ds-crehm please evaluate again.

@mkanal mkanal assigned ds-crehm and unassigned mkanal Jul 18, 2024
@mkanal mkanal moved this from review to test in Trace-X Jul 18, 2024
@ds-mwesener ds-mwesener moved this from test to wip in Trace-X Jul 18, 2024
@ds-mwesener ds-mwesener assigned ds-mwesener and unassigned ds-crehm Jul 18, 2024
@ds-mwesener ds-mwesener moved this from wip to test in Trace-X Jul 19, 2024
@ds-mwesener
Copy link
Contributor

@ds-crehm added feedback. Please validate on e2e.

@ds-mwesener ds-mwesener assigned ds-crehm and unassigned ds-mwesener Jul 19, 2024
@ds-crehm
Copy link
Contributor

Implemented like in the comment from @mkanal
German translation is missing.
Here a suggestion: "Keine Änderungen; Nichts zu speichern."

@ds-crehm ds-crehm moved this from test to wip in Trace-X Jul 19, 2024
@ds-crehm ds-crehm assigned ds-mwesener and unassigned ds-crehm Jul 19, 2024
@ds-mwesener ds-mwesener moved this from wip to test in Trace-X Jul 19, 2024
@ds-mwesener ds-mwesener assigned ds-crehm and unassigned ds-mwesener Jul 19, 2024
@ds-crehm
Copy link
Contributor

LGTM. German translation now implemented too.
Ready for review.

@ds-crehm ds-crehm moved this from test to review in Trace-X Jul 19, 2024
@ds-crehm ds-crehm assigned mkanal and unassigned ds-crehm Jul 19, 2024
@mkanal
Copy link
Contributor Author

mkanal commented Jul 19, 2024

LGFM. PO acceptance in behalf of @jzbmw .

@mkanal mkanal closed this as completed Jul 19, 2024
@mkanal mkanal moved this from review to done in Trace-X Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkanal mkanal

Labels
5 - Frontend Refactoring
Projects
Trace-X
Status: done
Milestone
No milestone
4 participants
@mkanal @ds-mmaul @ds-mwesener @ds-crehm