feat(ssi): adjust framework creation endpoint #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
ntruchsess
requested changes
Apr 18, 2024
| @@ -77,11 +77,11 @@ protected override Task HandleRequirementAsync(AuthorizationHandlerContext conte | |||
| private void InitializeClaims(ClaimsPrincipal principal) | |||
| { | |||
| var preferredUserName = principal.Claims.SingleOrDefault(x => x.Type == ClaimTypes.PreferredUserName)?.Value; | |||
| if (!Guid.TryParse(preferredUserName, out var identityId)) | |||
| var sub = principal.Claims.SingleOrDefault(x => x.Type == ClaimTypes.Sub)?.Value; | |||
| if (!Guid.TryParse(preferredUserName, out var identityId) && !Guid.TryParse(sub, out identityId)) | |||
There was a problem hiding this comment.
this is misleading as it results in log-message referring to preferredUserName
also 'sub' is not supposed to contain an identityId. It contains the keycloak users primary key (see the equivalent code in portal: https://github.com/eclipse-tractusx/portal-backend/blob/f43eadae29a5b93022e7794cec0381d970339637/src/web/Web.Identity/MandatoryIdentityClaimHandler.cs#L109 )
* adjust endpoint create framework credential to take the bpn of the request * adjust claim handler to support serviceAccounts as well
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
124
to
127
| catch (Exception e) | ||
| { | ||
| throw new ArgumentException($"{member.DeclaringType?.Name}.{member.Name} is not assignable from {expression}, {e.Message}", e); | ||
| } |
Check notice
Code scanning / CodeQL
Generic catch clause Note
src/database/SsiCredentialIssuer.Entities/Auditing/Attributes/AuditEntityV2Attribute.cs
Fixed
Show fixed
Hide fixed
adjust the identityId to string to be able to save the clientId of a technical user
ntruchsess
approved these changes
Apr 22, 2024
Phil91
force-pushed
the
feature/ssi
branch
4 times, most recently
from
38f0533 to
c2c1667
Compare
|
This was referenced Apr 23, 2024
This was referenced May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Why
The id of the technical user isn't taken correctly
Issue
N/A
Corresponding Backend PR
#646
Checklist