Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(revocation): add endpoints to revoke credentials #43

Merged
merged 7 commits into from
Apr 26, 2024
Merged

feat(revocation): add endpoints to revoke credentials #43

merged 7 commits into from
Apr 26, 2024

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Mar 27, 2024 •
edited by evegufy
Loading

Description

  • add endpoint for issuer to revoke a credential
  • add endpoint for holder to revoke a credential
  • add logic to revoke credentials when they are expired

Why

To give the holder of an issue and an issuer the possibility to revoke a specific credential

Issue

Refs: #14 #15 #16 #24

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas
  • I have added copyright and license headers, footers (for .md files) or files (for images)

@Phil91
Copy link
Member Author

Phil91 commented Mar 27, 2024

This PR also solves: https://github.com/eclipse-tractusx/ssi-credential-issuer/security/code-scanning/283

@Phil91 Phil91 force-pushed the feature/15-revocation branch 5 times, most recently from 9ba9efa to c178b39 Compare March 27, 2024 18:54
@Phil91 Phil91 mentioned this pull request Mar 27, 2024
Closed
@Phil91 Phil91 linked an issue Mar 27, 2024 that may be closed by this pull request
Credential Seeding Data Update 24.05. Scope #45
Closed
@Phil91 Phil91 force-pushed the feature/15-revocation branch from c178b39 to 64eceb7 Compare March 28, 2024 12:26
@Phil91 Phil91 force-pushed the feature/15-revocation branch from 64eceb7 to e08caa2 Compare March 28, 2024 12:34
@Phil91 Phil91 marked this pull request as ready for review March 28, 2024 13:08
@Phil91 Phil91 requested review from ntruchsess and evegufy March 28, 2024 13:08
@Phil91 Phil91 force-pushed the feature/15-revocation branch 3 times, most recently from 0bcc20f to 0b17ade Compare April 8, 2024 06:16
@Phil91 Phil91 force-pushed the feature/15-revocation branch 2 times, most recently from 75d16c7 to 09f4dc9 Compare April 10, 2024 10:16
@jjeroch jjeroch added the priority PR needs to prioritized at review label Apr 10, 2024
@evegufy evegufy changed the base branch from dev to release/v1.0.0-rc.2 April 15, 2024 15:53
@jjeroch jjeroch removed the priority PR needs to prioritized at review label Apr 16, 2024
@ntruchsess ntruchsess self-assigned this Apr 19, 2024
Base automatically changed from release/v1.0.0-rc.2 to main April 23, 2024 09:50
Phil91 added 4 commits April 24, 2024 14:16
@Phil91
feat(revocation): add endpoints to revoke credentials
1c333d1 
* add endpoint for issuer to revoke a credential
* add endpoint for holder to revoke a credential
* add logic to revoke credentials when they are expired

Refs: #14 #15 #16
@Phil91
feat(download): add credential download endpoint
5667ec5 
Refs: #24
@Phil91
chore: adjust statusList Url
7baa61b 
Refs: #15
@Phil91
feat(revocation): adjust revocation for holder
5639bd5 
Refs: #15
@Phil91 Phil91 force-pushed the feature/15-revocation branch from 6359c40 to 52f5ce9 Compare April 24, 2024 12:38
@Phil91 Phil91 force-pushed the feature/15-revocation branch from 52f5ce9 to 70f8e5e Compare April 24, 2024 13:14
@Phil91 Phil91 changed the base branch from main to release/v1.0.0-rc.3 April 24, 2024 13:28
ntruchsess
ntruchsess requested changes Apr 24, 2024
View reviewed changes
src/processes/Processes.Library/Processes.Library.csproj Outdated
@@ -35,6 +35,7 @@

<ItemGroup>
<PackageReference Include="Flurl.Http.Signed" Version="3.2.4" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
Copy link
Contributor

@ntruchsess ntruchsess Apr 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why those references? the project seems not to contain anything related to Flurt or Json (and we should use System.Text.Json, not Newtonsoft anyway)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're right, removed that

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
4.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@Phil91 Phil91 requested a review from ntruchsess April 25, 2024 10:26
@Phil91 Phil91 merged commit dc9c70d into release/v1.0.0-rc.3 Apr 26, 2024
9 of 11 checks passed
@Phil91 Phil91 deleted the feature/15-revocation branch April 26, 2024 11:18
@github-actions github-actions bot mentioned this pull request Apr 30, 2024
Merged
This was referenced May 23, 2024
Closed
Closed
Closed
Merged
Merged
Merged
@github-actions github-actions bot mentioned this pull request Oct 10, 2024
Closed
@github-actions github-actions bot mentioned this pull request Oct 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntruchsess ntruchsess ntruchsess approved these changes

@evegufy evegufy Awaiting requested review from evegufy

Assignees

@ntruchsess ntruchsess

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Credential Seeding Data Update 24.05. Scope
3 participants
@Phil91 @ntruchsess @jjeroch