feat: Internal issuer component enhance get credential endpoint by su… #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
tests/database/SsiCredentialIssuer.DbAccess.Tests/CompanySsiDetailsRepositoryTests.cs
Fixed
Show fixed
Hide fixed
tests/database/SsiCredentialIssuer.DbAccess.Tests/CompanySsiDetailsRepositoryTests.cs
Fixed
Show fixed
Hide fixed
|
business perspective sounds reasonable . |
Phil91
requested changes
Dec 3, 2024
| @@ -0,0 +1,8 @@ | |||
| namespace Org.Eclipse.TractusX.SsiCredentialIssuer.DBAccess.Models; | |||
| @@ -26,7 +26,7 @@ namespace Org.Eclipse.TractusX.SsiCredentialIssuer.Service.BusinessLogic; | |||
|
|
|||
| public interface IIssuerBusinessLogic | |||
| { | |||
| IAsyncEnumerable<UseCaseParticipationData> GetUseCaseParticipationAsync(); | |||
| IAsyncEnumerable<UseCaseParticipationData> GetUseCaseParticipationAsync(string? status); | |||
There was a problem hiding this comment.
You can directly user StatusType?
Suggested change
| IAsyncEnumerable<UseCaseParticipationData> GetUseCaseParticipationAsync(string? status); | |
| IAsyncEnumerable<UseCaseParticipationData> GetUseCaseParticipationAsync(StatusType? status); |
There was a problem hiding this comment.
Here the StatusType was not used because the error messages we have to throw to the user. They are customized and with the use of the object it self it would not be possible.
Comment on lines
+88
to
+98
| public IAsyncEnumerable<UseCaseParticipationData> GetUseCaseParticipationAsync(string? status) | ||
| { | ||
| StatusType? statusTypeResult = null; | ||
| if (!string.IsNullOrEmpty(status)) | ||
| { | ||
| if (!(Enum.TryParse<StatusType>(status, ignoreCase: true, out var statusType) || !Enum.IsDefined(typeof(StatusType), statusType))) | ||
| { | ||
| throw new ArgumentException($"Status value {status} is not valid; please use Active, Expired or All"); | ||
| } | ||
| statusTypeResult = statusType; | ||
| } |
There was a problem hiding this comment.
You can directly use StatusType, than the conversion isn't needed
Suggested change
| public IAsyncEnumerable<UseCaseParticipationData> GetUseCaseParticipationAsync(string? status) | |
| { | |
| StatusType? statusTypeResult = null; | |
| if (!string.IsNullOrEmpty(status)) | |
| { | |
| if (!(Enum.TryParse<StatusType>(status, ignoreCase: true, out var statusType) || !Enum.IsDefined(typeof(StatusType), statusType))) | |
| { | |
| throw new ArgumentException($"Status value {status} is not valid; please use Active, Expired or All"); | |
| } | |
| statusTypeResult = statusType; | |
| } | |
| public IAsyncEnumerable<UseCaseParticipationData> GetUseCaseParticipationAsync(StatusType? status) | |
| { | |
There was a problem hiding this comment.
Here is the same. When I use the type object I cannot have a customized message. At least I could not find a way to do that. I would be grateful to have a support here
| @@ -42,16 +42,18 @@ public static RouteGroupBuilder MapIssuerApi(this RouteGroupBuilder group) | |||
| { | |||
| var issuer = group.MapGroup("/issuer"); | |||
|
|
|||
| issuer.MapGet("useCaseParticipation", (IIssuerBusinessLogic logic) => logic.GetUseCaseParticipationAsync()) | |||
| issuer.MapGet("useCaseParticipation", (IIssuerBusinessLogic logic, | |||
| [FromQuery(Name = "status")] string? status) => logic.GetUseCaseParticipationAsync(status)) | |||
There was a problem hiding this comment.
Can be changed to StatusType as well
Suggested change
| [FromQuery(Name = "status")] string? status) => logic.GetUseCaseParticipationAsync(status)) | |
| [FromQuery(Name = "status")] StatusType? status) => logic.GetUseCaseParticipationAsync(status)) |
There was a problem hiding this comment.
The same here, it is just to have a customized error message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…pporting filters
Description
The purpose of this feature is to enhance the functionality of the existing GET /api/issuer/useCaseParticipation endpoint in the Issuer Component. The enhancement involves the ability to filter the returned list of use case participations by the status of the credentials (Active, Expired, or All).
Why
Instead of always returning all use case credentials it gives the customer the power of retrieving it by status.
Issue
NA
Checklist
Please delete options that are not relevant.