Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set credential to active only after credential exists #286

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Oct 23, 2024

Description

The credential is set to active only after it was created in the wallet

Why

To have the correct state when the credential isn't created yet

Issue

Refs: #285

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas
  • I have added copyright and license headers, footers (for .md files) or files (for images)

@Phil91 Phil91 requested a review from evegufy October 23, 2024 10:30
@Phil91 Phil91 added this to the Release 24.12 milestone Oct 23, 2024
Copy link

@evegufy evegufy changed the title fix: set credential to active after credential exists fix: set credential to active only after credential exists Oct 23, 2024
@Phil91 Phil91 merged commit af759bf into main Oct 24, 2024
12 checks passed
@Phil91 Phil91 deleted the bug/285-credential branch October 24, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

2 participants