Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api-hub): create open api spec on build #262

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Sep 26, 2024

Description

Generate open api spec on build of the issuer service

Why

To align with TRG 1.08

Issue

Refs: #256

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas
  • I have added copyright and license headers, footers (for .md files) or files (for images)

@Phil91
Copy link
Member Author

Phil91 commented Sep 26, 2024

This PR will fail until eclipse-tractusx/portal-backend#1030 is merged, until than it only works with building the nuget packages locally

@Phil91 Phil91 added this to the Release 24.12 milestone Sep 26, 2024
@evegufy evegufy changed the title feat: create open api spec on build feat(api-hub): create open api spec on build Sep 26, 2024
@Phil91 Phil91 force-pushed the feature/256-open-api branch from c75bf95 to dfd7eac Compare September 27, 2024 07:47
@Phil91 Phil91 marked this pull request as ready for review September 27, 2024 07:47
@Phil91 Phil91 force-pushed the feature/256-open-api branch 2 times, most recently from ce675b4 to a02b175 Compare September 27, 2024 09:46
@Phil91 Phil91 force-pushed the feature/256-open-api branch from a02b175 to ac351ed Compare September 30, 2024 12:49
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
50.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@Phil91
Copy link
Member Author

Phil91 commented Sep 30, 2024

Quality Gate Failed Quality Gate failed

Failed conditions 50.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

this can be ignored, the test coverage is mentioned for extension methods which only register settings and a service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

2 participants