Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(approval): send mail and notification to requester #101

Merged
merged 1 commit into from
May 12, 2024

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented May 6, 2024

Description

Adjust the mail and notification creation to create them for the requesting user instead of the calling user.

Why

Since the calling user is the operator, the requesting user is currently not informed about the approval / rejection of the credentials.

Issue

Refs: eclipse-tractusx/portal-backend#712

Corresponding Portal PR

713

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas
  • I have added copyright and license headers, footers (for .md files) or files (for images)

Copy link

sonarqubecloud bot commented May 6, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants