Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sig#781 - Adjust seeding data to support adding of initial credentials #250

Closed
2 tasks done
evegufy opened this issue Sep 17, 2024 · 7 comments
Closed
2 tasks done
Assignees
Labels
enhancement New feature or request

Comments

@evegufy
Copy link
Contributor

evegufy commented Sep 17, 2024

Description

The process through which the BPNL and Membership credentials for the initial/operator wallet is added to the Credential Issuer should be improved.
In the current state it requires direct interaction on database level to some extent: https://github.com/eclipse-tractusx/ssi-credential-issuer/blob/v1.1.0/docs/technical-documentation/operator-credential-creation/initial-credential-setup.md

Acceptance Criteria

  • Seeding data is enhanced to support adding of initial credentials
  • No direct interaction on db level is needed anymore to import the initial/operator wallet

Additional information

implements eclipse-tractusx/sig-release#781

@evegufy evegufy added the enhancement New feature or request label Sep 17, 2024
@github-project-automation github-project-automation bot moved this to NEW USER REQUEST in Portal Sep 17, 2024
@evegufy evegufy added this to the Release 24.12 milestone Sep 20, 2024
@evegufy evegufy moved this from NEW USER REQUEST to BACKLOG in Portal Sep 20, 2024
@Phil91
Copy link
Member

Phil91 commented Sep 26, 2024

@evegufy this issue is obsolete since I've adjusted the portal seeding in a way that the onboarding process will run for the operator company to create the wallet and the two credentials afterwards.

@MaximilianHauer fyi

@Phil91 Phil91 self-assigned this Sep 26, 2024
@evegufy
Copy link
Contributor Author

evegufy commented Oct 10, 2024

Hi @Phil91 we'd still need to update the documentation, right? https://github.com/eclipse-tractusx/ssi-credential-issuer/blob/v1.1.0/docs/technical-documentation/operator-credential-creation/initial-credential-setup.md
And wasn't there a 409 error due to issuer and holder being the same instance in the operator case, which we should take care of?

cc: @MaximilianHauer

@MaximilianHauer
Copy link
Contributor

MaximilianHauer commented Oct 10, 2024

The portal will request a bpn credential via the endpoint POST: api/issuer/bpn which will create a process and a process step. The process will currently fail at step 4 since the issuer wallet is the same as the holder wallet. This will be fixed in the future. For now you can execute the following query to resolve the issue

i assume we talk about this sentence ? would make sense to add the error code.

@Phil91
Copy link
Member

Phil91 commented Oct 11, 2024

@evegufy I adjust the documentation :)

Yes right, I add the handling for that in this PR as well. @MaximilianHauer this would make the error obsolete :)

@Phil91 Phil91 moved this from IN REVIEW to IN PROGRESS in Portal Oct 11, 2024
@MaximilianHauer
Copy link
Contributor

@Phil91 then i follow the finding of @evegufy and propose a documentation update ;)

Phil91 added a commit that referenced this issue Oct 14, 2024
* check if the holder equals the issuer, if so skip the import credential for holder step

Refs: #250
Phil91 added a commit that referenced this issue Oct 15, 2024
* check if the holder equals the issuer, if so skip the import credential for holder step

Refs: #250
Reviewed-By: Evelyn Gurschler <[email protected]>
@Phil91 Phil91 moved this from IN PROGRESS to IN REVIEW in Portal Oct 16, 2024
@evegufy evegufy closed this as completed Oct 18, 2024
@github-project-automation github-project-automation bot moved this from IN REVIEW to USER READY in Portal Oct 18, 2024
@evegufy evegufy reopened this Oct 21, 2024
@evegufy
Copy link
Contributor Author

evegufy commented Oct 21, 2024

docs still needs to be updated

@Phil91
Copy link
Member

Phil91 commented Oct 22, 2024

docs still needs to be updated

@evegufy added in #284

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

3 participants