Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hard error handling for conflicting resource #112

Closed
jjeroch opened this issue May 7, 2024 · 2 comments
Closed

Remove hard error handling for conflicting resource #112

jjeroch opened this issue May 7, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@jjeroch
Copy link
Contributor

jjeroch commented May 7, 2024

Description:
The current response of the API is returning a hard error for conflicting resources. This hard error is causing unnecessary restrictions and hindering the smooth functioning of the system.

API Response:

{
    "type": "https://tools.ietf.org/html/rfc7231#section-6.5.8",
    "title": "The resource is in conflict with the current request.",
    "status": 409,
    "errors": {
        "Org.Eclipse.TractusX.SsiCredentialIssuer.Service": [
            "There should only be one pending or active ssi detail be assigned"
        ]
    },
    "errorId": "368d63b3-0d12-4d36-9458-ce8d1ba10e2a",
    "details": [
        {
            "errorCode": "MULTIPLE_SSI_DETAIL",
            "type": "IssuerErrors",
            "message": "There should only be one pending or active ssi detail be assigned",
            "parameters": []
        }
    ]
}

Expected Behavior:
The hard validation for conflicting resources should be removed to allow for more flexibility in handling such scenarios. Instead of returning a hard error, a more informative and user-friendly error message should be provided, allowing the user to understand the issue and take appropriate actions.

@jjeroch jjeroch added the bug Something isn't working label May 7, 2024
@jjeroch jjeroch added this to the Release 24.05 milestone May 7, 2024
@jjeroch jjeroch added this to Portal May 7, 2024
@github-project-automation github-project-automation bot moved this to NEW USER REQUEST in Portal May 7, 2024
@jjeroch jjeroch moved this from NEW USER REQUEST to BACKLOG in Portal May 7, 2024
@jjeroch
Copy link
Contributor Author

jjeroch commented May 7, 2024

Example on INT: bpnl00000007

@Phil91
Copy link
Member

Phil91 commented May 7, 2024

Example on INT: bpnl00000007

Is this the correct bpn? there seems to be something missing at the end

@Phil91 Phil91 moved this from BACKLOG to IN PROGRESS in Portal May 8, 2024
Phil91 added a commit that referenced this issue May 8, 2024
* adding error handling if an already existing pending credential is requested again
* adjust response of api/issuer/useCaseParticipation & api/issuer/certificates to response with multiple ssi details

Refs: #110 #112
Phil91 added a commit that referenced this issue May 8, 2024
* adding error handling if an already existing pending credential is requested again
* adjust response of api/issuer/useCaseParticipation & api/issuer/certificates to response with multiple ssi details
-----------------
Refs: #110 #112
Reviewed-By: Evelyn Gurschler <[email protected]>
@Phil91 Phil91 moved this from IN PROGRESS to IN REVIEW in Portal May 8, 2024
@jjeroch jjeroch moved this from IN REVIEW to USER READY in Portal Jun 30, 2024
@evegufy evegufy closed this as completed Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants