Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable filter and adjust backend logic of the endpoint `GET /api/issuer/certificates #111

Closed
jjeroch opened this issue May 6, 2024 · 1 comment · Fixed by #120
Closed
Assignees
Labels
bug Something isn't working

Comments

@jjeroch
Copy link
Contributor

jjeroch commented May 6, 2024

Description:
Currently, the endpoint GET /api/issuer responds with all credentials. However, we need to enhance the endpoint to enable the user to only include credentials that require a separate approval.

Filter: Manuel vs Automatic

Manuel: Credential is only created if a manual approval is given
Automatic: No separate approval needed, credential created as part of configured/implemented workflows

Changes:

  1. Enable a filter to identify credentials that need a separate approval.
  2. Adjust the backend logic of the endpoint to only respond with credentials that require a separate approval.

Expected Outcome:
After implementing these changes, the endpoint GET /api/issuer will (depending on the used filter value) only return credentials that need a separate approval, ensuring better control and security in the credential issuance process.

Note if no filter value is provided, all credential are responded (as currently implemented)

@jjeroch jjeroch added the bug Something isn't working label May 6, 2024
@jjeroch jjeroch added this to the Release 24.05 milestone May 6, 2024
@jjeroch jjeroch added this to Portal May 6, 2024
@github-project-automation github-project-automation bot moved this to NEW USER REQUEST in Portal May 6, 2024
@jjeroch jjeroch moved this from NEW USER REQUEST to BACKLOG in Portal May 6, 2024
@Phil91
Copy link
Member

Phil91 commented May 10, 2024

@jjeroch the /certificates endpoint currently only returns membership and bpn credentials thus the returned values are all automatically approved. and we never will have a result for manual approval ones. I think the adjustment is only making sense if we combine the /certificates and /useCaseParticipation endpoint.

Phil91 added a commit that referenced this issue May 12, 2024
* add optional filter for approval type to endpoitn GET /api/issuer
* add Get document endpoint

Refs: #111 #27
Phil91 added a commit that referenced this issue May 13, 2024
* add optional filter for approval type to endpoitn GET /api/issuer
* add Get document endpoint

Refs: #111 #27
@Phil91 Phil91 moved this from BACKLOG to IN PROGRESS in Portal May 13, 2024
@Phil91 Phil91 linked a pull request May 13, 2024 that will close this issue
9 tasks
Phil91 added a commit that referenced this issue May 23, 2024
* add optional filter for approval type to endpoitn GET /api/issuer
* add Get document endpoint
----------------------
Refs: #111 #27
Reviewed-By: Evelyn Gurschler <[email protected]>
@jjeroch jjeroch moved this from IN PROGRESS to IN REVIEW in Portal Jul 24, 2024
@evegufy evegufy closed this as completed Oct 18, 2024
@github-project-automation github-project-automation bot moved this from IN REVIEW to USER READY in Portal Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants