Skip to content

Commit

Permalink
feat: add imagePullSecrets (#236)
Browse files Browse the repository at this point in the history
  • Loading branch information
mgarciaLKS authored Sep 19, 2024
1 parent 7501c13 commit bed4ff8
Show file tree
Hide file tree
Showing 5 changed files with 20 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@ spec:
template:
spec:

Check warning on line 35 in charts/ssi-credential-issuer/templates/cronjob-expiry-app.yaml

View workflow job for this annotation

GitHub Actions / Analyze

[MEDIUM] Service Account Token Automount Not Disabled

Service Account Tokens are automatically mounted even if not necessary
restartPolicy: OnFailure
{{- with .Values.credentialExpiry.image.pullSecrets }}
imagePullSecrets:
{{- toYaml . | nindent 8 }}
{{- end }}
containers:

Check warning on line 41 in charts/ssi-credential-issuer/templates/cronjob-expiry-app.yaml

View workflow job for this annotation

GitHub Actions / Analyze

[MEDIUM] Container Running With Low UID

Check if containers are running with low UID, which might cause conflicts with the host's user table.

Check warning on line 41 in charts/ssi-credential-issuer/templates/cronjob-expiry-app.yaml

View workflow job for this annotation

GitHub Actions / Analyze

[MEDIUM] Seccomp Profile Is Not Configured

Containers should be configured with a secure Seccomp profile to restrict potentially dangerous syscalls
- name: {{ include "issuer.fullname" . }}-{{ .Values.credentialExpiry.name }}
securityContext:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@ spec:
template:
spec:

Check warning on line 35 in charts/ssi-credential-issuer/templates/cronjob-issuer-processes.yaml

View workflow job for this annotation

GitHub Actions / Analyze

[MEDIUM] Service Account Token Automount Not Disabled

Service Account Tokens are automatically mounted even if not necessary
restartPolicy: OnFailure
{{- with .Values.processesworker.image.pullSecrets }}
imagePullSecrets:
{{- toYaml . | nindent 8 }}
{{- end }}
containers:

Check warning on line 41 in charts/ssi-credential-issuer/templates/cronjob-issuer-processes.yaml

View workflow job for this annotation

GitHub Actions / Analyze

[MEDIUM] Container Running With Low UID

Check if containers are running with low UID, which might cause conflicts with the host's user table.

Check warning on line 41 in charts/ssi-credential-issuer/templates/cronjob-issuer-processes.yaml

View workflow job for this annotation

GitHub Actions / Analyze

[MEDIUM] Seccomp Profile Is Not Configured

Containers should be configured with a secure Seccomp profile to restrict potentially dangerous syscalls
- name: {{ include "issuer.fullname" . }}-{{ .Values.processesworker.name }}
securityContext:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@ spec:
labels:
{{- include "issuer.selectorLabels" . | nindent 8 }}
spec:

Check warning on line 38 in charts/ssi-credential-issuer/templates/deployment-issuer-service.yaml

View workflow job for this annotation

GitHub Actions / Analyze

[MEDIUM] Service Account Token Automount Not Disabled

Service Account Tokens are automatically mounted even if not necessary
{{- with .Values.service.image.pullSecrets }}
imagePullSecrets:
{{- toYaml . | nindent 8 }}
{{- end }}
containers:

Check warning on line 43 in charts/ssi-credential-issuer/templates/deployment-issuer-service.yaml

View workflow job for this annotation

GitHub Actions / Analyze

[MEDIUM] Container Running With Low UID

Check if containers are running with low UID, which might cause conflicts with the host's user table.

Check warning on line 43 in charts/ssi-credential-issuer/templates/deployment-issuer-service.yaml

View workflow job for this annotation

GitHub Actions / Analyze

[MEDIUM] Seccomp Profile Is Not Configured

Containers should be configured with a secure Seccomp profile to restrict potentially dangerous syscalls
- name: {{ include "issuer.fullname" . }}
securityContext:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,10 @@ spec:
name: {{ include "issuer.fullname" . }}-{{ .Values.migrations.name }}
spec:
restartPolicy: Never
{{- with .Values.migrations.image.pullSecrets }}
imagePullSecrets:
{{- toYaml . | nindent 8 }}
{{- end }}
containers:
- name: {{ include "issuer.fullname" . }}-{{ .Values.migrations.name }}
securityContext:
Expand Down
4 changes: 4 additions & 0 deletions charts/ssi-credential-issuer/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ service:
image:
name: "docker.io/tractusx/ssi-credential-issuer-service"
tag: ""
pullSecrets: []
imagePullPolicy: "IfNotPresent"
# -- We recommend to review the default resource limits as this should a conscious choice.
resources:
Expand Down Expand Up @@ -75,6 +76,7 @@ migrations:
image:
name: "docker.io/tractusx/ssi-credential-issuer-migrations"
tag: ""
pullSecrets: []
imagePullPolicy: "IfNotPresent"
# -- We recommend to review the default resource limits as this should a conscious choice.
resources:
Expand All @@ -97,6 +99,7 @@ processesworker:
image:
name: "docker.io/tractusx/ssi-credential-issuer-processes-worker"
tag: ""
pullSecrets: []
imagePullPolicy: "IfNotPresent"
# -- We recommend to review the default resource limits as this should a conscious choice.
resources:
Expand Down Expand Up @@ -140,6 +143,7 @@ credentialExpiry:
image:
name: "docker.io/tractusx/ssi-credential-expiry-app"
tag: ""
pullSecrets: []
imagePullPolicy: "IfNotPresent"
# -- We recommend to review the default resource limits as this should a conscious choice.
resources:
Expand Down

0 comments on commit bed4ff8

Please sign in to comment.