Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:Test setup #201

Merged
merged 4 commits into from
Nov 23, 2023
Merged

fix:Test setup #201

merged 4 commits into from
Nov 23, 2023

Conversation

shijinrajbosch
Copy link
Contributor

@shijinrajbosch shijinrajbosch commented Nov 22, 2023 •
edited
Loading

Description

Fixed the jena-fuseki-docker version to 4.7.0 for the test case to fix #196

@SebastianBezold
Copy link
Contributor

HI @shijinrajbosch,

running mvn clean install on your branch still runs into test errors on my side. Unfortunately it doesn't provide a better output than the following, but at least the test names are visible:

[ERROR] Errors:
[ERROR]   ApplicationTest.contextLoads » ExceptionInInitializer
[ERROR]   SwaggerUITest.testGetRootExpectRedirectedToSwaggerUI » NoClassDefFound Could n...
[ERROR]   SwaggerUITest.testGetSwaggerUiExpect200 » NoClassDefFound Could not initialize...
[ERROR]   HealthCheckTest.testHealthEndpoint » NoClassDefFound Could not initialize clas...
[ERROR]   HealthCheckTest.testInfoEndpoint » NoClassDefFound Could not initialize class ...
[ERROR]   HealthCheckTest.testLivenessEndpoint » NoClassDefFound Could not initialize cl...
[ERROR]   HealthCheckTest.testReadinessEndpoint » NoClassDefFound Could not initialize c...
[ERROR]   ModelsApiFilterTest » NoClassDefFound Could not initialize class org.eclipse.t...
[ERROR]   ModelsApiPaginationTest » NoClassDefFound Could not initialize class org.eclip...
[ERROR]   ModelsApiSecurityTest » NoClassDefFound Could not initialize class org.eclipse...
[ERROR]   ModelsApiTest » NoClassDefFound Could not initialize class org.eclipse.tractus...

@shijinrajbosch shijinrajbosch mentioned this pull request Nov 22, 2023
Closed
@SebastianBezold
Copy link
Contributor

Thanks for clarifying @shijinrajbosch.

Summary: Pre-condition for building and running the tests is to have a locally available jena-fuseki-docker:4.7.0 docker image. I missed that, because i thought, it's only needed for running the app

From the README:

This docker image jena-fuseki-docker:4.7.0 will be used in the Helm deployment and test - values.yaml (graphdb.image).

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

SebastianBezold
SebastianBezold approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@SebastianBezold SebastianBezold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just a local issue on my side. So fine with me, if the build pipeline is working

tunacicek
tunacicek approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@tunacicek tunacicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tunacicek tunacicek merged commit 5ed30ef into eclipse-tractusx:main Nov 23, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tunacicek tunacicek tunacicek approved these changes

@SebastianBezold SebastianBezold SebastianBezold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TRG 7.04 IP checks for 3rd party content
3 participants
@shijinrajbosch @SebastianBezold @tunacicek