Feat: Cursor implementation done for GET request in ShellAPI and LookUp API #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Spring jdbc changed to spring jpa.
tunacicek
reviewed
Jul 10, 2023
.../org/eclipse/tractusx/semantics/registry/controller/AssetAdministrationShellApiDelegate.java
Outdated
Show resolved
Hide resolved
| @@ -118,21 +116,28 @@ public ResponseEntity<SubmodelDescriptor> getSubmodelDescriptorByIdThroughSuperp | |||
|
|
|||
| @Override | |||
| public ResponseEntity<AssetAdministrationShellDescriptor> postAssetAdministrationShellDescriptor( AssetAdministrationShellDescriptor assetAdministrationShellDescriptor ) { | |||
| Shell saved = shellService.save(shellMapper.fromApiDto(assetAdministrationShellDescriptor)); | |||
| Shell shell = shellMapper.fromApiDto(assetAdministrationShellDescriptor); | |||
There was a problem hiding this comment.
It would be better to handle this settings in the service layer or much better in the mapper
backend/src/main/java/org/eclipse/tractusx/semantics/registry/dto/ShellCollectionDto.java
Outdated
Show resolved
Hide resolved
tunacicek
reviewed
Jul 10, 2023
backend/src/main/java/org/eclipse/tractusx/semantics/registry/service/ShellService.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/org/eclipse/tractusx/semantics/registry/service/ShellService.java
Outdated
Show resolved
Hide resolved
tunacicek
reviewed
Jul 11, 2023
backend/src/main/java/org/eclipse/tractusx/semantics/registry/service/ShellService.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/org/eclipse/tractusx/semantics/registry/service/ShellService.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/org/eclipse/tractusx/semantics/registry/service/ShellService.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/org/eclipse/tractusx/semantics/registry/service/ShellService.java
Show resolved
Hide resolved
|
@agg3fe Do we have tests for cursor pag. ? |
|
Yes. Test cases are already there in AssetAdministrationShellApiTest class. |
tunacicek
reviewed
Jul 14, 2023
| List<SubmodelDescriptor> descriptorResults = submodelMapper.toApiDto( submodels ); | ||
| GetSubmodelDescriptorsResult result = new GetSubmodelDescriptorsResult(); | ||
| result.setResult( descriptorResults ); | ||
| Shell savedShell = shellService.findShellByExternalId(aasIdentifier,externalSubjectId); |
There was a problem hiding this comment.
please use getExternalSubjectIdOrEmpty(externalSubjectId)
Also updated CHANGELOG.md file.
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cursor implementation done for pagination search for GET requests in ShellAPI and LookUp API.
The spring jdbc has been changed to spring JPA.