Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deployment): enable readOnlyRootFilesystem #190

Conversation

typecastcloud
Copy link
Contributor

@typecastcloud typecastcloud commented Jul 9, 2024

Why

  1. This resolves KSV014 from trivy.
  2. Is also required by guideline: https://eclipse-tractusx.github.io/docs/release/trg-4/trg-4-07/

Description

Activate readOnlyRootFilesystem setting in helm values.
Mount temporary directory to allow writes.

Fixes: #189

Pre-review checks

@typecastcloud typecastcloud requested review from adkumar1 and evegufy July 9, 2024 13:43
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
@adkumar1 please review and let me know once I should merge

@adkumar1
Copy link
Contributor

LGTM

@adkumar1
Copy link
Contributor

There are no DEPENDENCIES file related changes with this PR.
We can remove that file changes from this PR

@typecastcloud
Copy link
Contributor Author

There are no DEPENDENCIES file related changes with this PR. We can remove that file changes from this PR

Removed it. As maintainer you can also edit PR. I make against this repository.

@typecastcloud
Copy link
Contributor Author

Please ping me if there is something missing in this PR. Thank you!

@evegufy
Copy link
Contributor

evegufy commented Jul 25, 2024

@adkumar1 I will go ahead with the merge, ok?

@adkumar1
Copy link
Contributor

Yes, good to go

@evegufy evegufy merged commit d3c6e5f into eclipse-tractusx:main Jul 31, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TRG 4.07: Read-Only Filesystem
3 participants