Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/migrate to edc 0.5.x #93

Merged
merged 12 commits into from
Dec 3, 2023
Merged

Refactor/migrate to edc 0.5.x #93

merged 12 commits into from
Dec 3, 2023

Conversation

eschrewe
Copy link
Contributor

Description

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@gitguardian GitGuardian
Copy link

gitguardian bot commented Nov 21, 2023 •
edited
Loading

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 21, 2023
View reviewed changes
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KICS found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@eschrewe eschrewe force-pushed the refactor/migrate_to_edc_0.5.x branch 9 times, most recently from 91894a8 to e293095 Compare November 21, 2023 10:09
tom-rm-meyer-ISST
tom-rm-meyer-ISST requested changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall great, I guess the half of the stuff are documentation things (Please check out for "Format of a Doc comment" in official oracle documentation). Overall only minor things. Very few things I wans't sure about.

backend/Dockerfile Outdated Show resolved Hide resolved
backend/src/main/java/org/eclipse/tractusx/puris/backend/AssetCreatorCommandLineRunner.java Show resolved Hide resolved
backend/src/main/java/org/eclipse/tractusx/puris/backend/DataInjectionCommandLineRunner.java Show resolved Hide resolved
NOTICE.md Outdated Show resolved Hide resolved
.../main/java/org/eclipse/tractusx/puris/backend/common/api/logic/service/VariablesService.java Show resolved Hide resolved
local/miw/infrastructure.properties Outdated Show resolved Hide resolved
local/miw/infrastructure.properties Outdated Show resolved Hide resolved
local/tractus-x-edc/config/customer/control-plane.properties Outdated Show resolved Hide resolved
local/tractus-x-edc/config/customer/control-plane.properties Outdated Show resolved Hide resolved
local/tractus-x-edc/config/supplier/data-plane.properties Outdated Show resolved Hide resolved
@eschrewe eschrewe force-pushed the refactor/migrate_to_edc_0.5.x branch from 4914cf8 to c8f5828 Compare November 23, 2023 13:28
@tom-rm-meyer-ISST
Copy link
Contributor

@eschrewe IP check succeeded. Please merge with latest main and tag me again to merge. Thank's a lot for this contribution!

@eschrewe
Merge branch 'main' into refactor/migrate_to_edc_0.5.x
fb1bcbc 
# Conflicts:
#	backend/src/main/java/org/eclipse/tractusx/puris/backend/common/api/logic/service/VariablesService.java
#	backend/src/main/java/org/eclipse/tractusx/puris/backend/common/edc/logic/util/EDCRequestBodyBuilder.java
#	backend/src/main/resources/application-customer.properties
#	backend/src/main/resources/application-supplier.properties
#	backend/src/main/resources/application.properties
#	backend/src/test/resources/application.properties
#	local/.env
#	local/INSTALL.md
#	local/docker-compose.yaml
#	local/tractus-x-edc/config/customer/control-plane.properties
#	local/tractus-x-edc/config/supplier/control-plane.properties
@eschrewe
chore: updated dependencies backend
0a38c90
@tom-rm-meyer-ISST tom-rm-meyer-ISST mentioned this pull request Dec 3, 2023
Closed
tom-rm-meyer-ISST
tom-rm-meyer-ISST approved these changes Dec 3, 2023
View reviewed changes
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, IP check succeeded.

I opened #101 for some refactorings of namings in the EdcClasses.

@tom-rm-meyer-ISST tom-rm-meyer-ISST merged commit fa4b736 into eclipse-tractusx:main Dec 3, 2023
8 checks passed
This was referenced Dec 3, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-rm-meyer-ISST tom-rm-meyer-ISST tom-rm-meyer-ISST approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eschrewe @tom-rm-meyer-ISST