fix: helm deployment #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaMarzec
changed the title
- feat: added new application.properties to deployment.yaml,values.yaml and their README's - feat: splitted NOTES text to 'local' and 'internet' after deployment with ingress enabled - feat: added edc.controlplane.data.path to values.yaml's and to deployment.yaml
PaMarzec
force-pushed
the
fix/helm-delployment
branch
from
d7c413e to
bc57885
Compare
mhellmeier
previously requested changes
Nov 10, 2023
tom-rm-meyer-ISST
requested changes
Nov 13, 2023
There was a problem hiding this comment.
Good progress.
- Please update the pullPolicies for ALL images in helm
- Make the Frontend talk to the Backend out of the box using default values.
- Get the ingress running locally
- Harmonize backend application properties.
I also noted that the ENDPOINT_MATERIAL in Frontend is not resolved. I guess the env variable is ENDPOINT_MATERIALS
…n values,fixed backendBaseUrl
PaMarzec
force-pushed
the
fix/helm-delployment
branch
from
a70581c to
2a1ad72
Compare
tom-rm-meyer-ISST
requested changes
Nov 23, 2023
…oyable Signed-off-by: Pascal Marzec <[email protected]>
PaMarzec
force-pushed
the
fix/helm-delployment
branch
from
b490486 to
179fdff
Compare
Signed-off-by: Pascal Marzec <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
KICS found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
This was
linked to
issues
Dec 6, 2023
tom-rm-meyer-ISST
requested changes
Dec 6, 2023
…ackend-deployment.yaml Signed-off-by: Pascal Marzec <[email protected]>
tom-rm-meyer-ISST
requested changes
Dec 10, 2023
… to 8181/8184 Signed-off-by: Pascal Marzec <[email protected]>
There was a problem hiding this comment.
KICS found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
tom-rm-meyer-ISST
dismissed
mhellmeier’s stale review
fixed things meanwhile. Took over responsibility.
tom-rm-meyer-ISST
merged commit 7eeb128
into
eclipse-tractusx:main
11 of 12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the new application.properties to the associated values.yaml and deployment.yaml of the helm charts. Additionally it splits the deployment message into "local deployment" and "internet deployment"
Resolves #87 ,#85 ,#68
Creates #110
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: