Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: edited license headers #562

Conversation

eschrewe
Copy link
Contributor

Description

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

  • DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
  • Copyright and license header are present on all affected files
  • If helm chart has been changed, the chart version has been bumped to either next major, minor or patch level (compared to released chart).

@eschrewe
Copy link
Contributor Author

Won't do chart version bumb here...

@tom-rm-meyer-ISST tom-rm-meyer-ISST linked an issue Aug 26, 2024 that may be closed by this pull request
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Found 4 places where 2023 has been placed instead of 2024.

Added suggestion so that you can also add them to a commit as a batch, via files tab :)

Also did some cross-checks with following regex (\(c\) [0-9]{4}) for find all (ctrl + shift + f) in the directory of repository and found more files. Please check

local/generate-keys.sh Show resolved Hide resolved
local/init-wallets.sh Show resolved Hide resolved
local/vault/put-keys.sh Show resolved Hide resolved
local/cleanup.sh Show resolved Hide resolved
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for raising!

@tom-rm-meyer-ISST tom-rm-meyer-ISST merged commit ace7231 into eclipse-tractusx:main Sep 2, 2024
13 of 14 checks passed
@tom-rm-meyer-ISST tom-rm-meyer-ISST deleted the chore/edit_licenseheaders branch September 2, 2024 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update of license headers
2 participants