Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: demandandcapacitynotification_swaggerui #514

Merged
merged 3 commits into from
Jul 23, 2024
Merged

fix: demandandcapacitynotification_swaggerui #514

merged 3 commits into from
Jul 23, 2024

Conversation

eschrewe
Copy link
Contributor

Description

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

  • DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
  • Copyright and license header are present on all affected files
  • If helm chart has been changed, the chart version has been bumped to either next major, minor or patch level (compared to released chart).

@tom-rm-meyer-ISST tom-rm-meyer-ISST linked an issue Jul 22, 2024 that may be closed by this pull request
Swagger UI for Demand and Capacity Notification through EDC does not contain the header #487
Closed
tom-rm-meyer-ISST
tom-rm-meyer-ISST requested changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Issue is solved. While checking the swagger ui, I recognized one inconsistency I would be grateful if you could fix it, too :)

...andandcapacitynotification/controller/DemandAndCapacityNotificationRequestApiController.java Show resolved Hide resolved
@tom-rm-meyer-ISST tom-rm-meyer-ISST mentioned this pull request Jul 23, 2024
Closed
tom-rm-meyer-ISST
tom-rm-meyer-ISST approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@tom-rm-meyer-ISST tom-rm-meyer-ISST merged commit 260c08e into eclipse-tractusx:main Jul 23, 2024
12 checks passed
@tom-rm-meyer-ISST tom-rm-meyer-ISST deleted the fix/demandandcapacitynotification_swaggerui branch July 23, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-rm-meyer-ISST tom-rm-meyer-ISST tom-rm-meyer-ISST approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Swagger UI for Demand and Capacity Notification through EDC does not contain the header
2 participants
@eschrewe @tom-rm-meyer-ISST