Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Publishing cxId to DTR #483

Conversation

eschrewe
Copy link
Contributor

@eschrewe eschrewe commented Jul 5, 2024

Description

  • i noticed that when the triggerPartTypeRetrievalTask method is called, there is currently no mechanism to make sure that a cx id that was fetched as a result of that method call is immediately published to the respective shell descriptor at the DTR.
  • the fix for this is to initiate a DtrRegistration Task instead of just a PartTypeInformationRetrievalTask. A DtrRegistrationTask will always trigger a PartTypeInformationRetrievalTask when it notices that there is a missing CX id from a supplier partner. But beyond that it will also send an update for the approriate shell descriptor to the DTR

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

  • DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
  • Copyright and license header are present on all affected files
  • If helm chart has been changed, the chart version has been bumped to either next major, minor or patch level (compared to released chart).

Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for raising

@tom-rm-meyer-ISST tom-rm-meyer-ISST merged commit f3e0575 into eclipse-tractusx:main Jul 8, 2024
12 checks passed
@tom-rm-meyer-ISST tom-rm-meyer-ISST deleted the fix/publish_cxid_to_dtr branch July 8, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants