Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Mandatory change in licensing #468

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

eschrewe
Copy link
Contributor

@eschrewe eschrewe commented Jun 20, 2024

Description

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please also update NOTICE.md in folders frontend and backend.

I meanwhile check if this change also influences the docker notice and the file ending of the documentation files (see comment, gonna ask tomorrow in office hour)

@tom-rm-meyer-ISST
Copy link
Contributor

@eschrewe the questions pointed out will be adressed next week. For now no need to update

  • the docker notice
  • the documentation footer

@tom-rm-meyer-ISST tom-rm-meyer-ISST linked an issue Jun 21, 2024 that may be closed by this pull request
5 tasks
@eschrewe
Copy link
Contributor Author

Thanks! Please also update NOTICE.md in folders frontend and backend.

I meanwhile check if this change also influences the docker notice and the file ending of the documentation files (see comment, gonna ask tomorrow in office hour)

I updated the NOTICE.md in the backend folder. The frontend folder does not contain a NOTICE.md.

Since we don't know for sure, whether individual NOTICE.md in /frontend and /backend folder are required at all, Malte decided that we leave the /frontend folder as it currently is and merge that branch in order to meet the deadline tomorrow.

@eschrewe eschrewe requested a review from mhellmeier June 27, 2024 07:50
@mhellmeier mhellmeier dismissed tom-rm-meyer-ISST’s stale review June 27, 2024 09:00

I will take over the review due to unavailability of tom-rm-meyer-ISST.

Copy link
Member

@mhellmeier mhellmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The open points mentioned by @tom-rm-meyer-ISST and @eschrewe have to be considered but shouldn't block this PR.

@mhellmeier mhellmeier merged commit 4a96013 into eclipse-tractusx:main Jun 27, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mandatory change in licensing and legal documentation
3 participants