Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Updated trivy workflow #452

Merged
merged 3 commits into from
Jun 14, 2024
Merged

chore: Updated trivy workflow #452

merged 3 commits into from
Jun 14, 2024

Conversation

RoKrish14
Copy link
Contributor

@RoKrish14 RoKrish14 commented Jun 14, 2024 •
edited
Loading

Description

Updates:

  1. retrieves latest release of Trivy versions

  2. resolves failure of workflows (except High and Critical findings)
    exit-code: "1"
    limit-severities-for-sarif: true

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 14, 2024
View reviewed changes
.github/workflows/trivy.yml Fixed Show fixed Hide fixed
.github/workflows/trivy.yml Fixed Show fixed Hide fixed
tom-rm-meyer-ISST
tom-rm-meyer-ISST requested changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising. Let's stick to the commit hashes + dependabot (manual update)

.github/workflows/trivy.yml Outdated Show resolved Hide resolved
.github/workflows/trivy.yml Outdated Show resolved Hide resolved
RoKrish14 and others added 2 commits June 14, 2024 16:05
@RoKrish14 @tom-rm-meyer-ISST
chore: Updated trivy workflow
131c1f7 
Thanks for the suggestion.

Co-authored-by: Tom Meyer <[email protected]>
@RoKrish14 @tom-rm-meyer-ISST
chore: Updated trivy workflow
6eb1435 
Co-authored-by: Tom Meyer <[email protected]>
tom-rm-meyer-ISST
tom-rm-meyer-ISST approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@tom-rm-meyer-ISST tom-rm-meyer-ISST merged commit 0b01cb2 into eclipse-tractusx:main Jun 14, 2024
12 checks passed
@tom-rm-meyer-ISST tom-rm-meyer-ISST mentioned this pull request Jun 14, 2024
Closed
@RoKrish14 RoKrish14 deleted the RoKrish14-patch-1 branch June 20, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-rm-meyer-ISST tom-rm-meyer-ISST tom-rm-meyer-ISST approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RoKrish14 @tom-rm-meyer-ISST