Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implemented DemandAndCapacityNotification frontend #451

Merged
merged 5 commits into from
Jun 17, 2024
Merged

feat: implemented DemandAndCapacityNotification frontend #451

merged 5 commits into from
Jun 17, 2024

Conversation

ReneSchroederLJ
Copy link
Member

@ReneSchroederLJ ReneSchroederLJ commented Jun 14, 2024 •
edited
Loading

Description

  • implemented a new view for displaying DemandAndCapacityNotifications
  • notifications are divided in incoming and outgoing notifications
  • new notifications can be created through a modal

resolves #315

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@ReneSchroederLJ ReneSchroederLJ marked this pull request as ready for review June 14, 2024 13:53
tom-rm-meyer-ISST
tom-rm-meyer-ISST requested changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing. Great Quality! Just had a few findings or questions. please check

frontend/src/features/notifications/components/NotificationInformationModal.tsx Outdated Show resolved Hide resolved
frontend/src/features/notifications/components/NotificationInformationModal.tsx Outdated Show resolved Hide resolved
frontend/src/features/notifications/components/NotificationInformationModal.tsx Outdated Show resolved Hide resolved
frontend/src/features/notifications/components/NotificationInformationModal.tsx Show resolved Hide resolved
frontend/src/features/notifications/components/NotificationInformationModal.tsx Outdated Show resolved Hide resolved
frontend/src/views/DemandCapacityNotificationView.tsx Outdated Show resolved Hide resolved
frontend/src/views/DemandCapacityNotificationView.tsx Outdated Show resolved Hide resolved
frontend/src/features/notifications/components/NotificationInformationModal.tsx Show resolved Hide resolved
tom-rm-meyer-ISST
tom-rm-meyer-ISST approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your efforts!

@tom-rm-meyer-ISST tom-rm-meyer-ISST merged commit 1c06609 into eclipse-tractusx:main Jun 17, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-rm-meyer-ISST tom-rm-meyer-ISST Awaiting requested review from tom-rm-meyer-ISST

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Message Frontend
2 participants
@ReneSchroederLJ @tom-rm-meyer-ISST