Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci(helm-test): don't fail on chart version check failure #450

Merged

Conversation

tom-rm-meyer-ISST
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST commented Jun 14, 2024

Description

We currently do not always release every change in the helm chart. Thus increasing the version leads to confusion.

As a result I updated the workflow to

  • exclude version check as a failure reason during lint
  • in the end perform version check to fail (reminder to check on what to do)

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@tom-rm-meyer-ISST tom-rm-meyer-ISST force-pushed the ci/helm-version-warning branch from bcf6f25 to dc0626a Compare June 20, 2024 17:13
@tom-rm-meyer-ISST
Copy link
Contributor Author

Raised this issue to change strict handling of failed pipelines to ignore helm.

@tom-rm-meyer-ISST tom-rm-meyer-ISST force-pushed the ci/helm-version-warning branch from dc0626a to 2304034 Compare June 20, 2024 17:18
@tom-rm-meyer-ISST tom-rm-meyer-ISST marked this pull request as ready for review June 20, 2024 17:25
@tom-rm-meyer-ISST tom-rm-meyer-ISST removed the request for review from mhellmeier June 21, 2024 05:56
@tom-rm-meyer-ISST tom-rm-meyer-ISST force-pushed the ci/helm-version-warning branch 2 times, most recently from 03fdfc3 to 5f1e53f Compare June 21, 2024 06:24
@tom-rm-meyer-ISST tom-rm-meyer-ISST force-pushed the ci/helm-version-warning branch from 5f1e53f to a48a72d Compare June 21, 2024 11:58
@tom-rm-meyer-ISST
Copy link
Contributor Author

I disabled helm workflow failure to block merging via otterdog. Also temporary disabled CodeQl to block as I was not able to configure it correctly in otterdog

@mhellmeier mhellmeier merged commit faed123 into eclipse-tractusx:main Jun 21, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants