Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/erpadapter request client #443

Merged
merged 14 commits into from
Jun 20, 2024
Merged

Feat/erpadapter request client #443

merged 14 commits into from
Jun 20, 2024

Conversation

eschrewe
Copy link
Contributor

  • added a client service that sends request messages to the ERP adapter
  • added properties to configure the request target url and required credentials
  • added a unit test for the above mentioned service

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

tom-rm-meyer-ISST
tom-rm-meyer-ISST requested changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contributions. Please check smaller findings :)

...va/org/eclipse/tractusx/puris/backend/erpadapter/logic/service/ErpAdapterRequestService.java Outdated Show resolved Hide resolved
charts/puris/templates/backend-deployment.yaml Show resolved Hide resolved
charts/puris/values.yaml Show resolved Hide resolved
...org/eclipse/tractusx/puris/backend/erpadapter/logic/service/ErpAdapterRequestClientTest.java Show resolved Hide resolved
...org/eclipse/tractusx/puris/backend/erpadapter/logic/service/ErpAdapterRequestClientTest.java Outdated Show resolved Hide resolved
...org/eclipse/tractusx/puris/backend/erpadapter/logic/service/ErpAdapterRequestClientTest.java Outdated Show resolved Hide resolved
...org/eclipse/tractusx/puris/backend/erpadapter/logic/service/ErpAdapterRequestClientTest.java Outdated Show resolved Hide resolved
tom-rm-meyer-ISST
tom-rm-meyer-ISST requested changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! Currently some tests are failing due to missing properties in the test application properties. Beside that we can already include a mechanism to enable /disable the adapter :)

charts/puris/templates/backend-deployment.yaml Show resolved Hide resolved
charts/puris/values.yaml Show resolved Hide resolved
backend/src/test/resources/application.properties Show resolved Hide resolved
...org/eclipse/tractusx/puris/backend/erpadapter/logic/service/ErpAdapterRequestClientTest.java Outdated Show resolved Hide resolved
tom-rm-meyer-ISST
tom-rm-meyer-ISST requested changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great refactoring! Just a few minor things left :)

I meanwhile raised an issue #455 to cleanup conditional properties - We should check that e.g. the application also starts if values are missing if we disable something :)

...java/org/eclipse/tractusx/puris/backend/common/security/ErpAdapterSecurityConfiguration.java Outdated Show resolved Hide resolved
...org/eclipse/tractusx/puris/backend/erpadapter/logic/service/ErpAdapterRequestClientTest.java Outdated Show resolved Hide resolved
...org/eclipse/tractusx/puris/backend/erpadapter/logic/service/ErpAdapterRequestClientTest.java Outdated Show resolved Hide resolved
...org/eclipse/tractusx/puris/backend/erpadapter/logic/service/ErpAdapterRequestClientTest.java Outdated Show resolved Hide resolved
charts/puris/templates/backend-secrets.yaml Outdated Show resolved Hide resolved
...java/org/eclipse/tractusx/puris/backend/common/security/ErpAdapterSecurityConfiguration.java Outdated Show resolved Hide resolved
...java/org/eclipse/tractusx/puris/backend/common/security/ErpAdapterSecurityConfiguration.java Outdated Show resolved Hide resolved
tom-rm-meyer-ISST
tom-rm-meyer-ISST requested changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refactoring! I just found some styling issues.

backend/src/main/java/org/eclipse/tractusx/puris/backend/common/util/VariablesService.java Outdated Show resolved Hide resolved
backend/src/main/java/org/eclipse/tractusx/puris/backend/common/util/VariablesService.java Show resolved Hide resolved
...org/eclipse/tractusx/puris/backend/erpadapter/logic/service/ErpAdapterRequestClientTest.java Outdated Show resolved Hide resolved
...org/eclipse/tractusx/puris/backend/erpadapter/logic/service/ErpAdapterRequestClientTest.java Show resolved Hide resolved
tom-rm-meyer-ISST
tom-rm-meyer-ISST approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution! Thanks a lot! :)

@tom-rm-meyer-ISST tom-rm-meyer-ISST merged commit 8263810 into eclipse-tractusx:main Jun 20, 2024
13 checks passed
@tom-rm-meyer-ISST tom-rm-meyer-ISST deleted the feat/erpadapter_request branch June 20, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-rm-meyer-ISST tom-rm-meyer-ISST tom-rm-meyer-ISST approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eschrewe @tom-rm-meyer-ISST