feat: added updating of root folder dependencies #285
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaMarzec
force-pushed
the
feat/update-root-folder-dependencies
branch
from
344658b to
c1dddfb
Compare
PaMarzec
force-pushed
the
feat/update-root-folder-dependencies
branch
from
c1dddfb to
b34c6fc
Compare
tom-rm-meyer-ISST
requested changes
Apr 15, 2024
tom-rm-meyer-ISST
requested changes
Apr 17, 2024
There was a problem hiding this comment.
Building Backend now works. Please also do the following:
- Update the Frontend Dockerfile the same way
- Remove the duplicate files in Frontend and Backend folder (SECURITY.md, LICENSE, DEPENDENCIES) -> those need to be copied
- update docs/DEVELOPMENT.md that currently says one need to update the DEPENDENCIES in to places per frontend/ backend
As a result:
- no duplicate files in frontend/backend folder, that are present on root level
- following files are included in the images at the same location as the distributable (jar / http resources) following this TRG:
- NOTICE.md
- NOTICE_DOCKER.md
- SECURITY.md
- README.md
- LICENSE
| @@ -27,6 +27,9 @@ RUN mvn dependency:go-offline | |||
| COPY src/ /app/src/ | |||
| RUN mvn clean package -DskipTests | |||
|
|
|||
| # Copy Legal information for distributions | |||
| COPY DOCKER_NOTICE.md README.md SECURITY.md* LICENSE* DEPENDENCIES* /opt/app/ | |||
There was a problem hiding this comment.
I missed that we also need the NOTICE.md. Please add.
|
already handled via #389 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
resolves 49
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: