Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/edc catalog view #284

Merged

Conversation

eschrewe
Copy link
Contributor

@eschrewe eschrewe commented Mar 5, 2024

@tom-rm-meyer-ISST tom-rm-meyer-ISST linked an issue Mar 6, 2024 that may be closed by this pull request
Copy link
Contributor

@f-zimmer f-zimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semantically fine, just some minor syntactic suggestions/requests

@eschrewe eschrewe requested a review from f-zimmer March 6, 2024 16:04
Copy link
Contributor

@f-zimmer f-zimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the adjustments!

Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tom-rm-meyer-ISST tom-rm-meyer-ISST merged commit c60aa79 into eclipse-tractusx:main Mar 8, 2024
12 checks passed
@tom-rm-meyer-ISST tom-rm-meyer-ISST deleted the fix/edc_catalog_view branch March 8, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EDC Views show code 200 when EDC communication has an error
3 participants