-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/edc catalog view #284
Fix/edc catalog view #284
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Semantically fine, just some minor syntactic suggestions/requests
...nd/src/main/java/org/eclipse/tractusx/puris/backend/common/edc/controller/EdcController.java
Outdated
Show resolved
Hide resolved
...nd/src/main/java/org/eclipse/tractusx/puris/backend/common/edc/controller/EdcController.java
Outdated
Show resolved
Hide resolved
...nd/src/main/java/org/eclipse/tractusx/puris/backend/common/edc/controller/EdcController.java
Outdated
Show resolved
Hide resolved
...nd/src/main/java/org/eclipse/tractusx/puris/backend/common/edc/controller/EdcController.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the adjustments!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
edc controllers will no longer return status 200, if they didn't receive an ok-message from the control plane, solving EDC Views show code 200 when EDC communication has an error #282
edited various methods in EdcAdapterService, so that they now return the full response from the control plane (including the status code)
removed unneeded method in EdcAdapter
DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
Copyright and license header are present on all affected files