Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(frontend/Dockerfile): removed sponge from base image #265

Merged
merged 3 commits into from
Feb 23, 2024
Merged

ci(frontend/Dockerfile): removed sponge from base image #265

merged 3 commits into from
Feb 23, 2024

Conversation

tom-rm-meyer-ISST
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST commented Feb 22, 2024 •
edited
Loading

Description

Per TRG 4.02 no additional packages should be installed. @tomaszbarwicki provided workaround ideas that have been incorporated.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

tomaszbarwicki
tomaszbarwicki approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@tomaszbarwicki tomaszbarwicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tom-rm-meyer-ISST tom-rm-meyer-ISST merged commit f110640 into eclipse-tractusx:main Feb 23, 2024
13 checks passed
@tom-rm-meyer-ISST tom-rm-meyer-ISST deleted the ci/remove-sponge-from-base-image branch February 23, 2024 10:49
@tom-rm-meyer-ISST tom-rm-meyer-ISST mentioned this pull request May 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaszbarwicki tomaszbarwicki tomaszbarwicki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tom-rm-meyer-ISST @tomaszbarwicki