Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(frontend/Dockerfile): change from stable-alpine to alpine for nginx #259

Merged
merged 4 commits into from
Feb 22, 2024
Merged

ci(frontend/Dockerfile): change from stable-alpine to alpine for nginx #259

merged 4 commits into from
Feb 22, 2024

Conversation

tom-rm-meyer-ISST
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST commented Feb 21, 2024 •
edited
Loading

Description

Move from stable-alpine to common alpine image as stated in TRG 4.06. Also updated docker notice.

Added Healthcheck for Frontend Dockerfile

Updated Docker Notices / Readmes

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 21, 2024
View reviewed changes
frontend/Dockerfile Fixed Show fixed Hide fixed
mhellmeier
mhellmeier approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@mhellmeier mhellmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhellmeier mhellmeier merged commit fbe130a into eclipse-tractusx:main Feb 22, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhellmeier mhellmeier mhellmeier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tom-rm-meyer-ISST @mhellmeier