Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: material identification #224

Merged
merged 4 commits into from
Jan 30, 2024
Merged

refactor: material identification #224

merged 4 commits into from
Jan 30, 2024

Conversation

eschrewe
Copy link
Contributor

@eschrewe eschrewe commented Jan 29, 2024 •
edited
Loading

  • moved logic to identify material based on materialNumberCx, customerMatNbr and supplierMatNbr to MaterialService

  • added unit tests for this

  • DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.

  • Copyright and license header are present on all affected files

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 29, 2024
View reviewed changes
...in/java/org/eclipse/tractusx/puris/backend/masterdata/logic/service/MaterialServiceImpl.java Fixed Show resolved Hide resolved
...in/java/org/eclipse/tractusx/puris/backend/masterdata/logic/service/MaterialServiceImpl.java Dismissed Show dismissed Hide dismissed
...in/java/org/eclipse/tractusx/puris/backend/masterdata/logic/service/MaterialServiceImpl.java Dismissed Show dismissed Hide dismissed
...in/java/org/eclipse/tractusx/puris/backend/masterdata/logic/service/MaterialServiceImpl.java Dismissed Show dismissed Hide dismissed
...in/java/org/eclipse/tractusx/puris/backend/masterdata/logic/service/MaterialServiceImpl.java Dismissed Show dismissed Hide dismissed
...in/java/org/eclipse/tractusx/puris/backend/masterdata/logic/service/MaterialServiceImpl.java Dismissed Show dismissed Hide dismissed
...in/java/org/eclipse/tractusx/puris/backend/masterdata/logic/service/MaterialServiceImpl.java Dismissed Show dismissed Hide dismissed
...in/java/org/eclipse/tractusx/puris/backend/masterdata/logic/service/MaterialServiceImpl.java Dismissed Show dismissed Hide dismissed
...d/src/test/java/org/eclipse/tractusx/puris/backend/masterdata/logic/MaterialServiceTest.java Dismissed Show dismissed Hide dismissed
...in/java/org/eclipse/tractusx/puris/backend/masterdata/logic/service/MaterialServiceImpl.java Fixed Show fixed Hide fixed
tom-rm-meyer-ISST
tom-rm-meyer-ISST requested changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change itself looks great and I have nothing to add here.

The ItemStockSammMapperTest now fails. Likely because the mocks, mock on lower level and not the new serviceMethod. Please check.

tom-rm-meyer-ISST
tom-rm-meyer-ISST approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for refactoring!

@tom-rm-meyer-ISST tom-rm-meyer-ISST merged commit 709e4a4 into eclipse-tractusx:main Jan 30, 2024
12 checks passed
@tom-rm-meyer-ISST tom-rm-meyer-ISST deleted the refactor/material_identification branch January 30, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-rm-meyer-ISST tom-rm-meyer-ISST tom-rm-meyer-ISST approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eschrewe @tom-rm-meyer-ISST