Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/frameworkagreement #223

Conversation

eschrewe
Copy link
Contributor

  • added env variables to allow configuration of whether and which framework agreement shall be used

  • added request body creation method for framework agreement policy

  • added registration method in EdcAdapterService

  • configured local setup to use framework agreement by default

  • updated init-wallets.sh to include registration for framework agreement at miw

  • DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.

  • Copyright and license header are present on all affected files

Copy link
Contributor

@f-zimmer f-zimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'd just resolve this minor issue, but it's not necessary.

local/init-wallets.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@f-zimmer f-zimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall great contribution! please update the test application.properties :)

backend/src/test/resources/application.properties Outdated Show resolved Hide resolved
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

@tom-rm-meyer-ISST tom-rm-meyer-ISST merged commit 5b13d3d into eclipse-tractusx:main Feb 1, 2024
12 checks passed
@tom-rm-meyer-ISST tom-rm-meyer-ISST deleted the feat/frameworkagreement branch February 1, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add a contract policy based on a framework agreement (based on an application.properties)
4 participants