fix(authentication-service): don't pass redirectUrl if undefined

eclipse-tractusx · Nov 21, 2024 · 0f3cf9a · 0f3cf9a
1 parent a12db3e
commit 0f3cf9a
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/charts/puris/README.md b/charts/puris/README.md
@@ -188,7 +188,7 @@ dependencies:
 | frontend.puris.keycloak.clientId | string | `"appXYZ"` | Name of the client which is used for the application. |
 | frontend.puris.keycloak.disabled | bool | `true` | Disable the Keycloak integration. |
 | frontend.puris.keycloak.realm | string | `"Catena-X"` | Name of the Realm of the keycloak instance. |
-| frontend.puris.keycloak.redirectUrlFrontend | string | `"https://your-frontend-url.com"` | URL to use as keycloak redirect url. |
+| frontend.puris.keycloak.redirectUrlFrontend | string | `"https://your-frontend-url.com"` | URL to use as keycloak redirect url. If empty the frontend will not pass it for authentication. |
 | frontend.puris.keycloak.url | string | `"https://idp.com/auth"` | The URL to the IDP that should be used. |
 | frontend.puris.rateLimiting.burst | int | `30` | Burst rate limiting for nginx. |
 | frontend.puris.rateLimiting.limit | string | `"10m"` | Bucket zone limit for rate limiting in nginx. |

diff --git a/charts/puris/values.yaml b/charts/puris/values.yaml
@@ -204,7 +204,7 @@ frontend:
       realm: "Catena-X"
       # -- Name of the client which is used for the application.
       clientId: "appXYZ"
-      # -- URL to use as keycloak redirect url.
+      # -- URL to use as keycloak redirect url. If empty the frontend will not pass it for authentication.
       redirectUrlFrontend: "https://your-frontend-url.com"
     rateLimiting:
       # -- Bucket zone limit for rate limiting in nginx.

diff --git a/frontend/src/services/authentication-service.ts b/frontend/src/services/authentication-service.ts
@@ -40,8 +40,8 @@ const init = () => {
         keycloak
             .init({
                 onLoad: 'login-required',
-                redirectUri: config.auth.IDP_REDIRECT_URL_FRONTEND,
-                enableLogging: true,
+                redirectUri: config.auth.IDP_REDIRECT_URL_FRONTEND || undefined,
+                pkceMethod: 'S256'
             })
             .then((authenticated) => {
                 if (!authenticated) {