fix(roles): update role name for approval notifications in appmarketplace #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently Service Manager receives notifications regarding app approval process. Refs: eclipse-tractusx#370
|
@evegufy please tell me if I should rebase to main. |
the branch is perfect, no rebase needed |
evegufy
approved these changes
Jul 16, 2024
|
@typecastcloud thanks for the fix! |
tfjanjua
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
@typecastcloud , since you have removed Service Manager because it was the wrong role placed under the AppMarketplace param, please make sure that the Service Manager role is placed in the correct position.
This change will resolve the issue of App Manager so, change looks fine to me though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For appmarketplace, changed approveAppUserRoles role1 to "App Manager".
Why
Currently Service Manager receives notifications regarding app approval process. App Manager seems to be the appropriate user role to receive this notification.
Issue
Refs: #370
Checklist