fix(select list): update select list default value (#87)

eclipse-tractusx · Jan 30, 2024 · f017634 · f017634
1 parent c8ed680
commit f017634
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## 2.1.22
+
+- Select list default value functionality fix
+
 ## 2.1.21
 
 - Add option to give an image element to Cards

diff --git a/DEPENDENCIES b/DEPENDENCIES
@@ -1266,7 +1266,7 @@ npm/npmjs/@rollup/pluginutils/5.0.2, MIT, approved, clearlydefined
 npm/npmjs/@sinclair/typebox/0.24.51, MIT, approved, #3330
 npm/npmjs/@sinclair/typebox/0.27.8, MIT, approved, clearlydefined
 npm/npmjs/@sinonjs/commons/1.8.6, BSD-3-Clause, approved, #4340
-npm/npmjs/@sinonjs/commons/3.0.0, BSD-3-Clause, approved, clearlydefined
+npm/npmjs/@sinonjs/commons/3.0.0, BSD-3-Clause, approved, #12905
 npm/npmjs/@sinonjs/fake-timers/10.3.0, BSD-3-Clause, approved, #9214
 npm/npmjs/@sinonjs/fake-timers/9.1.2, BSD-3-Clause, approved, #1957
 npm/npmjs/@storybook/addon-actions/7.0.26, MIT, approved, #8972

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@catena-x/portal-shared-components",
-  "version": "2.1.21",
+  "version": "2.1.22",
   "description": "Catena-X Portal Shared Components",
   "author": "Catena-X Contributors",
   "license": "Apache-2.0",

diff --git a/src/components/basic/SelectList/SelectList.stories.tsx b/src/components/basic/SelectList/SelectList.stories.tsx
@@ -79,6 +79,7 @@ SelectList.args = {
   clearText: 'clear',
   noOptionsText: 'No Options',
   popperHeight: 0, // 0 = auto size
+  defaultValue: countries[0],
   onChangeItem: (item: any) => console.log('selected:', item),
   keyTitle: 'title',
 }
diff --git a/src/components/basic/SelectList/index.tsx b/src/components/basic/SelectList/index.tsx
@@ -65,7 +65,7 @@ export const SelectList = ({
   const selectHeight = popperHeight ? `${popperHeight}px` : 'auto'
   // Add an ESLint exception until there is a solution
   // eslint-disable-next-line
-  const [selected, setSelected] = useState<any>({})
+  const [selected, setSelected] = useState<any>(defaultValue || {})
   return (
     <Autocomplete
       id="singleSelectList"

diff --git a/src/components/content/Cards/Card.tsx b/src/components/content/Cards/Card.tsx
@@ -122,8 +122,7 @@ export const Card = ({
 
   useEffect(() => {
     sortOption !== '' &&
-      submenuClick !== undefined &&
-      submenuClick(sortOption, id)
+      submenuClick?.(sortOption, id)
   }, [sortOption, submenuClick, id])
 
   useEffect(() => {