Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notification): adjust create notification role #169

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Aug 8, 2024

Description

Adjust the create notification role to be specific for its use case

Why

The create_notifications role was to generic and is only used for the ssi related notifications

Issue

Refs: #812

Corresponding Backend PR

eclipse-tractusx/portal-backend#906

Corresponding SSI PR

eclipse-tractusx/ssi-credential-issuer#233

Checklist

  • I have followed the contributing guidelines
  • I have added copyright and license headers, footers (for .md files) or files (for images)
  • I have performed a self-review of my changes
  • I have successfully tested my changes
  • I have added comments in the default values.yaml file with helm-docs syntax ('# -- ') if relevant for installation
  • I have commented my changes, particularly in hard-to-understand areas

Copy link

sonarqubecloud bot commented Aug 8, 2024

@Phil91 Phil91 merged commit 63dad28 into main Sep 20, 2024
8 checks passed
@Phil91 Phil91 deleted the feature/812-create-notification branch September 20, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

3 participants