Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup - Notification Endpoints #812

Closed
jjeroch opened this issue Jun 25, 2024 · 3 comments · Fixed by #906
Closed

Cleanup - Notification Endpoints #812

jjeroch opened this issue Jun 25, 2024 · 3 comments · Fixed by #906
Assignees
Labels
breaking change PR shall be handled with extra care as it breaks existing functionality Sub-task A small piece of work that's part of a larger task.

Comments

@jjeroch
Copy link
Contributor

jjeroch commented Jun 25, 2024

Validation and explanation needed why we have 2 different "Create" notification endpoints:

image
@jjeroch jjeroch added the Sub-task A small piece of work that's part of a larger task. label Jun 25, 2024
@jjeroch jjeroch added this to the Release 2.1.0 milestone Jun 25, 2024
@jjeroch jjeroch added this to Portal Jun 25, 2024
@github-project-automation github-project-automation bot moved this to NEW USER REQUEST in Portal Jun 25, 2024
@jjeroch jjeroch moved this from NEW USER REQUEST to BACKLOG in Portal Jun 25, 2024
@Phil91
Copy link
Member

Phil91 commented Jun 25, 2024

@jjeroch there should only be one endpoint to create credentials (for the ssi decline, approve and expiry use cases), the other one is to just update the read status of a notification

@Phil91 Phil91 moved this from BACKLOG to IN PROGRESS in Portal Jun 25, 2024
@jjeroch jjeroch added the breaking change PR shall be handled with extra care as it breaks existing functionality label Jun 30, 2024
@jjeroch
Copy link
Contributor Author

jjeroch commented Jun 30, 2024

@Phil91 thanks.
I like to do an adjustment here - the endpoint is super specific for SSI Credentials.
I don't see a reason why we make it so specific.
We should apply an update to change the endpoint name

  • Endpoint Path: /api/notification
  • Method: POST
  • Description: Allows externals to create per POST mechanism a notification creation inside the portal to display the notification to a customer.

Additional needed change: adjust the attribute requester to receiver
Please recheck the logic to set the creator user ID - it must be assured that the creator is always correctly set based on the technical user or company user which runs the endpoint.

#breakingChange #internalBreaking

@jjeroch jjeroch moved this from IN PROGRESS to BACKLOG in Portal Jul 4, 2024
@Phil91
Copy link
Member

Phil91 commented Aug 8, 2024

@MaximilianHauer @ntruchsess as discussed the create endpoint will stay as it is for the specific useCase of creating a notification for the credentials. We will adjust the role to be more specific from create_notifications to create_ssi_notifications

Phil91 added a commit to eclipse-tractusx/ssi-credential-issuer that referenced this issue Aug 8, 2024
@ntruchsess ntruchsess linked a pull request Aug 14, 2024 that will close this issue
8 tasks
Phil91 added a commit that referenced this issue Aug 14, 2024
@github-project-automation github-project-automation bot moved this from IN PROGRESS to USER READY in Portal Aug 14, 2024
Phil91 added a commit to AnuragNagpure/portal-backend that referenced this issue Sep 6, 2024
Phil91 added a commit to eclipse-tractusx/ssi-credential-issuer that referenced this issue Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change PR shall be handled with extra care as it breaks existing functionality Sub-task A small piece of work that's part of a larger task.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants