Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(company data): error handling #905

Conversation

manojava-gk
Copy link
Contributor

@manojava-gk manojava-gk commented Jul 5, 2024

Description

  1. remove unwanted inputs
  2. fix crash issue if any of the values are missing in the respose
  3. error handling

Why

change request

Issue

#887 #888 #894

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@manojava-gk manojava-gk marked this pull request as ready for review July 5, 2024 06:53
@manojava-gk manojava-gk requested review from oyo and lavanya-bmw July 5, 2024 06:53
Copy link
Contributor

@lavanya-bmw lavanya-bmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@evegufy evegufy changed the base branch from release/v2.1.0-RC1 to release/v2.1.0-RC2 July 12, 2024 15:32
@manojava-gk manojava-gk requested a review from oyo July 15, 2024 07:03
@oyo oyo merged commit fd2f834 into eclipse-tractusx:release/v2.1.0-RC2 Jul 16, 2024
6 checks passed
@oyo oyo deleted the fix/issues-894-companydata-changes branch July 16, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants